#23 Drop val_t__xxx() macros

[Anonymous]

Originally created by: fge
Originally owned by: chassell

They are simply wrappers in order to access the ->v.xxx configuration values, except for two of them, which access other fields, which make them even more confusing.

What's more, theirs being usable as lvalues is touted as a feature in the header file: I call that a bad quirk.

And finally, they are too uncomfortably close in writing to the val_t_to_* function.

I say, drop them.

[Anonymous]

Originally posted by: djmitche

This sounds like a good cleanup. The file has a lot of needless complexity, but those macros are particularly loathsome.

The conffile module is well-tested, and I would also be amenable to a much more thorough rewrite to use some existing parsing libraries. If that could add some more flexibility in the configuration (macros, perhaps, or variables?), that would be even better. That's probably another bug, though

[Anonymous]

Originally posted by: chassell

I've worked on a better layer for this.