From: Steven Augart <steve@Augart.com> - 2002-02-12 21:22:10
Anyone want to collaborate with me and figure out whether we should
make certain changes in callbacks.cpp?
Here are the problems I see:
**The server reservation (6 lines) is code repeated in a number of places;
should be consolidated into a method of the Server class (something
**There's a synchronization problem with the server reservation code.
Only way to fix this is to go over to using a proper Posix 1003.1c mutex.
**Other places need checks for whether a current server exists.
I made on_expunge_menu_activate() dump core.
A couple of other functions do use assertions to confirm that there's
a current server. A step in the right direction, but obviously a user
action should never trigger an assertion.
It would be good to have this code modularized and put it there. I
think we should add an Althea::get_current_server_or_gripe() method.
**When <Print> is clicked, check for whether there's a current message
before popping up the dialogue box, not after.
Get latest updates about Open Source Projects, Conferences and News.