Menu

#82 Various issues with Compare Windows etc

9.0b1
closed
None
Bug
AlphaTcl
major
2017-03-15
2017-01-22
No

The Compare Windows functionality has some shortcomings: the diff window has default geometry, the compared windows are not resized, focus in the compared windows does not follow the diff selection in the diff window.

Discussion

  • Bernard Desgraupes

    Hi Joachim,
    I'm aware of all the issues related to the Compare menu and precisely I wanted to contact you about them. I tried to dive in the code there but found it very difficult to understand the overall mechanism based on temporary marks. So it would certainly be more reliable (and much appreciated!) if you could have a look yourself.

     
  • Joachim Kock

    Joachim Kock - 2017-01-24

    I think the main problems have been fixed: a namespace issue with the command [mark], the curious problem that row numbers were assumed to start at 0 (should be 1) --- this mistake is more than 10 years old, but it was never detected because AlphaX silently corrected 0 to 1. A few other minor issues.

    The basic functionality works now, but there are still some things to be ironed out, including the geometry issues, which depend on Bug #84 and some flickering due to Bug #88. And some whitespace problems that I want to debug further.

     
  • Joachim Kock

    Joachim Kock - 2017-02-12

    There were several problems with marks, tempfiles and geometry. I think it all works now.

    I have taken the opportunity to eliinate two prefs flags: synchroniseMoveAndView and resizeWindowsWhenDone. The first is deemed meaningless since the whole point of Diff Mode is to step through the diffs while they are displayed side by side. The second is obsolete since the tempgeometry package now takes care of resizing in a consistent way.

    I propose this bug be closed. It is probably better to log further Diff Mode issues separately.

     
  • Bernard Desgraupes

    • status: open --> fixed
    • Version: 9.0a11 --> 9.0a14
     
  • Bernard Desgraupes

    • status: fixed --> closed
    • Version: 9.0a14 --> 9.0b1
     

Log in to post a comment.