Some remarks about the Search menu.
If I select a search string in the "Find bar" (the one on the top of a
document panel) and then select cmd-G (Find again) it does not search that
string, but the last one entered in the "Find..." dialog. However, the
menu give the expectation that "Find again" could apply to both the "Find
bar" and the "Find..." dialog since the three are grouped together.
The same for Replace: it applies to the string given in the "Find..." dialog
even if the Find bar (with the "replace" box checked) is open.
I suggest to group together the entries that work together:
- Find...
- Find Again
- Replace
- Replace & Find Again
- Replace All
- "Enter Search string" again apply only to the "Find..." box. Its meaning was unclear for me at first sight. "Use selection as search string" ?
- Show find bar. Note : it is strange to have the "Show find bar" item in the menu and the "Hide Find bar" when you hold the alt key, irrespective of the actual state of the Find bar. Either it is off, in which case it has no sense to be able to click ""Hide Find bar", or it is on, in which case it has no sense to have the "Show find bar". I suggest to have the "Show find bar"/"Hide find bar", irrespectively to the alt key, but according to the actual state of the Find bar. The same shorkcut (shift-cmd-F) could show and hide according to the actual state, rather than having two shortcuts (shift-cmd-F and shift-alt-cmd-F).
- "Toggle incremental searching/Toggle non-incremental searching" (in replacement of "incremental searching" in the windows info)
- Quick find
- Reverse Quick find
- Hyper Search...
- Next Match : does not seems to work.
- Matching Lines... : does not seem to work (?)
I'm wondering if it could be interesting to have a "stop" button while searching a fileset (if the search goes into
large file hierarchy it can take a while before it stops).
The Search menu has undergone a first round of reorganization and revision. Now the navigation bindings ⌘G for Find Next and ⇧⌘G for Find Previous are shared by the usual Find mechanism and by the Find Bar. The command Enter Search String (⌘E) also enters the search string in the Find Bar if it is visible.
There is now a single item to show or hide the Find Bar: it changes depending on the visibility of the Find Bar in the current window and is bound to ⇧⌘F.
There is also an item to turn incremental searches (with the Find Bar) on or off. You do not have any longer to find this setting in the File popup (which I admit was ridiculous).
Still to deal with the Matching Lines issue you reported.
The remaining issue concerning the Matching Lines command seems to be fixed now.
Additionally I have implemented something similar for the replacement string. The command findBar configure now has a -replaceString option and the menu item Enter Replace String (⌥⌘E) installs the replace string in the Find Bar if it is visible.
Changes committed to the repository (rev. 1186). The core must be rebuilt.