Apache Allura / Chat

Apache Allura / Chat is hosted on FreeNode IRC channel #allura

Log for 2013-09-12

  • 18:05:10
    brondsem

    i have a commit that needs a review. it's my own changes on [#6613] which i was reviewing

  • 18:05:22
    brondsem

    a little lengthy but most of those changes are trivial

  • 18:26:14
    cory_fu

    You could use pop('TicketMonitoringEmail', None) instead of try / except / pass. But there isn't any fallout from cahnging results['tracker_config'] from the actual config instance to the json() dict?

  • 18:28:18
    brondsem

    catching KeyError does also protect if the 'options' isn't there for some reason. that'd be unusual though

  • 18:28:51
    brondsem

    since the method is @expose('json') the json() is called by TG

  • 18:29:00
    cory_fu

    True. I had considered that but figured it shouldn't really come up. I'd leave it with the except / pass, though, just to be safe

  • 18:29:03
    brondsem

    .. called automatically, now its explicit

  • 18:30:24
    cory_fu

    Fair enough. So, I guess if all those many test changes pass, seems ok

  • 18:30:49
    brondsem

    thanks

  • 18:35:25
    ASFBot

    Allura/320: #320 started building, estimated 12 minutes left. https://builds.apache.org/job/allura/320/

  • 18:35:25
    ASFBot

    yuriyarhipovua: [6613] ticket:428 Tracker API include config & milestones & saved bins

  • 18:35:26
    ASFBot

    dbrondsema: [6613] don't expose TicketMonitoringEmail in API, and associated TestRestApiBase changes

  • 18:48:00
    ASFBot

    Allura/320: #320 built successfully after 12 minutes https://builds.apache.org/job/allura/320/

  • 19:08:50
    brondsem

    tvansteenburgh: I was trying to figure out what's going on with [#6647]

  • 19:09:09
    brondsem

    i'm pretty sure the cron that pulls new git code isn't triggering the refresh

  • 19:09:18
    brondsem

    but i don't have access to the cron, or don't know where it is

  • 19:09:19
    tvansteenburgh

    orly

  • 19:09:25
    tvansteenburgh

    lemme check

  • 19:09:37
    brondsem

    yeah, didn't see anything in the access logs from curl or wget etc

  • 19:10:29
    tvansteenburgh

    oh

  • 19:10:31
    tvansteenburgh

    /5 * * * . /var/local/env-allura/bin/activate; cd /var/local/allura; ./update.sh; git push local master; curl http://allura-vm.apache.org/p/allura/git/refresh;

  • 19:10:39
    brondsem

    ah :)

  • 19:11:01
    brondsem

    i assume that's in the crontab for the allura or root user?

  • 19:11:07
    tvansteenburgh

    allura

  • 19:11:30
    brondsem

    yeah. i should figure out how to get my access set up on the VM

  • 19:13:08
    tvansteenburgh

    updated the domain, presumably it'll work now

  • 19:14:23
    brondsem

    cool, thanks :)

  • 19:14:59
    tvansteenburgh

    np, should've checked that when you mentioned it before, didn't even occur to me

  • 20:40:26
    brondsem

    tvansteenburgh: can we expand that cron to pull & push all branches & tags?

  • 20:50:05
    tvansteenburgh

    sure

  • 20:52:50
    tvansteenburgh

    ok, i changed it to git push

  • 20:53:14
    tvansteenburgh

    already a generic git pull since it's using the update.sh script

  • 20:53:57
    tvansteenburgh

    hm, guess i need git push --tags instead?

  • 20:54:46
    brondsem

    iirc --tags does only tags

  • 20:55:20
    brondsem

    git push --all ?

  • 20:55:58
    tvansteenburgh

    --all --tags ?

  • 20:56:11
    tvansteenburgh

    i thought --all was just heads

  • 20:56:13
    tvansteenburgh

    not tags

  • 20:56:39
    brondsem

    yeah, both it looks like

  • 20:56:48
    brondsem

    both params are needed

  • 20:57:07
    tvansteenburgh

    ok, cron updated

  • 20:58:08
    brondsem

    for pull, doesn't a generic git pull just do the current branch?

  • 20:59:19
    brondsem

    there's an --all but docs indicate that's only for fetching, not merging into local

  • 21:15:13
    tvansteenburgh

    getting confused now

  • 21:15:21
    tvansteenburgh

    do we need to locally track all branches?

  • 21:16:11
    brondsem

    not necessarily, but we want to show them all on the web I think

  • 21:17:06
    brondsem

    it seems a little complicated to me since we're pulling into one repo location and then pushing into the one we use for web browsing

  • 21:42:42
    tvansteenburgh

    ok, i think i've got it sorted

  • 21:42:58
    tvansteenburgh

    will see when the repo refresh finishes

  • 21:47:39
    brondsem

    man, if only we didn't have this ridiculously long analyzing step :)

  • 21:51:29
    brondsem

    must be looking at a lot of new branches

  • 22:05:02
    tvansteenburgh

    bah

  • 22:05:12
    tvansteenburgh

    now the page takes forever to load, but still only shows master

  • 22:05:46
    tvansteenburgh

    i'll look into it tomorrow, don't have time right now, time for dinner

  • 22:05:54
    brondsem

    ok

  • 22:05:57
    brondsem

    tags are there though