SourceForge has been redesigned. Learn more.
Close

Apache Allura / Chat

Apache Allura / Chat is hosted on FreeNode IRC channel #allura

Log for 2013-09-04

  • 08:11:27
    Humbedooh

    ASFBot: tell brondsem report looks good :)

  • 08:11:28
    ASFBot

    I'll pass that along, Humbedooh!

  • 13:19:41
    ASFBot

    brondsem: 5 hours and 8 minutes ago, Humbedooh said; report looks good :)

  • 13:20:38
    ASFBot

    Allura/297: #297 started building, estimated 12 minutes left. https://builds.apache.org/job/allura/297/

  • 13:22:43
    tvansteenburgh

    brondsem: some questions wrt [#6100]

  • 13:22:54
    tvansteenburgh

    it works fine, but...

  • 13:23:03
    tvansteenburgh
    1. it doesn't handle multiple moves
  • 13:23:49
    tvansteenburgh
    1. not sure how i feel about using the custom fields for storing the prior location values
  • 13:24:01
    tvansteenburgh

    thoughts?

  • 13:25:10
    brondsem

    yeah, those don't sound the best to me either. Let me take a cursory look at the code

  • 13:26:02
    brondsem

    not much code :)

  • 13:26:15
    tvansteenburgh

    yeah, that was a nice feature of this ticket :)

  • 13:26:32
    brondsem

    better impl might be a lot more though, we'll see

  • 13:26:45
    brondsem

    yeah, using a custom field is also going to be really slow for lookups on a large db

  • 13:27:45
    tvansteenburgh

    true, i hadn't even thought of that

  • 13:28:12
    brondsem

    there is an index on import_id, so that could be re-used. I think [#6541] makes that more flexible too

  • 13:28:39
    brondsem

    i had been thinking more along the lines of having a new artifact for MovedTicket which would have a URL to the new location

  • 13:28:56
    brondsem

    then those could be chained and the client gets multiple redirects

  • 13:28:59
    tvansteenburgh

    yeah, that way you could just follow the chain

  • 13:29:08
    tvansteenburgh

    yeah, what you said :P

  • 13:29:20
    brondsem

    it'd also have the flexibility to redirect to an external URL. which I suspect we may want to do when we start moving our own tickets from SF allura to ASF allura

  • 13:29:29
    brondsem

    at least backend support for it

  • 13:30:19
    tvansteenburgh

    so if a ticket is missing, the code does a lookup on the MovedTicket collection?

  • 13:30:32
    brondsem

    we don't allow mount point changes, so storing a URL path should be fine. The current impl is a little more flexible in that regard, storing a app_config_id, but not too big a deal I guess

  • 13:30:35
    brondsem

    yeah

  • 13:31:20
    tvansteenburgh

    well we could store whatever we want right, any reason to not store the app config id?

  • 13:32:09
    brondsem

    I guess only if we wanted to redirect to an arbitrary url instead

  • 13:32:33
    tvansteenburgh

    oh true

  • 13:32:53
    brondsem

    that's not necessarily a requirement at this point though. but seems like it might be nice

  • 13:33:52
    tvansteenburgh

    yeah, i'll tell them to just store the url that the ticket is moving to

  • 13:33:53
    brondsem

    another thing - the ticket API should be updated too. Probably just return a 301 instead of 404

  • 13:34:09
    tvansteenburgh

    ah, right, good catch

  • 13:34:32
    ASFBot

    Allura/297: #297 built successfully after 13 minutes https://builds.apache.org/job/allura/297/

  • 13:39:52
    tvansteenburgh

    MovedArtifact instead? with a moved_to_url field

  • 13:41:32
    tvansteenburgh

    hm, i guess you'd end up with MovedTicket extending that, since you'd need to store ticket_nu

  • 13:41:39
    brondsem

    yeah, a generic class might be useful elsewhere. We'd still need a way to do the lookup by a specific key (ticket_num) so that might necessitate ….. yes

  • 13:41:50
    brondsem

    :)

  • 13:42:04
    tvansteenburgh

    ok

  • 14:36:15
    ASFBot

    Allura/298: #298 started building, estimated 13 minutes left. https://builds.apache.org/job/allura/298/

  • 14:48:49
    ASFBot

    Allura/298: #298 built successfully after 12 minutes https://builds.apache.org/job/allura/298/

  • 15:32:49
    ASFBot

    Allura/299: #299 started building, estimated 12 minutes left. https://builds.apache.org/job/allura/299/

  • 15:32:49
    ASFBot

    dbrondsema: [6530] bump wiki importer versions

  • 15:45:06
    ASFBot

    Allura/299: #299 built successfully after 12 minutes https://builds.apache.org/job/allura/299/