Apache Allura / Chat is hosted on FreeNode IRC channel #allura
so I was looking at the recent "rat" failures. it'd be easy to add CHANGES to the ignore file
I'm not sure what to do with ForgeImporters/forgeimporters/tests/data/google/empty-issue.html and test-issue.html
it is HTML from google code, used for testing. I have no idea what sort of licensing that would fall under
outbound email on our apache instance is working now, just verified my email address
tvansteenburgh: I've been thinking it would be nice if get_page took a parse=True/False flag for pages that aren't HTML, like the CSV issues list, so it could use the same caching, etc. shrug
i already refactored that :D
I'm reviewing that now
You made parse_page overridable, but what if some pages want parsing and some don't? Or two pages use different parsing. I guess that logic still belongs in the subclass
yeah, YAGNI. build it when we need it
I needed it in the GC tracker importer for the CSV issues list; that is a different format than the rest of the pages, so I had to drop back to urlopen()
I guess parse_page can look at self.url or something
i see. the most flexible would be to optionally pass in a parser callable to get_page()
i kinda like that idea
Worth adding to the refactors in 6531?
sure, why not. who's doing it, you or me?
shrug I'm done with 6530 for the moment, so if you're working on something else, I can do it
Then we can make Dave review 6531 and then add his changes. :-p
lol, that's what i was thinking
go for it, i'm working on getting inbound email working on apache instance
seems like i do in fact to need a different port for inbound email, b/c 25 is already being used for outbound
so i can bind that port with our custom handler
tvansteenburgh:  Clean up tests
Yippie, build fixed!
tvansteenburgh: New commit pushed to your tv/6531 branch
Want to take a look since brondsem isn't around?
Hrm. Just noticed that I didn't fix a docstring when I reverted a false-start I made
I'll fix the DEFAULT_PARSER bit in get_page's docstring
Force-pushed the doc fix
extractor = GoogleCodeProjectExtractor(None, url, parser=stringio_parser)
why is parser being passed to init?
It gets passed through to get_page
Just didn't want to type the extra .get_page
the diff looks good, i did not run the tests b/c i'm in the middle of another ticket
if the tests pass, it's good by me