Apache Allura / Chat

Apache Allura / Chat is hosted on FreeNode IRC channel #allura

Log for 2013-08-23

  • 14:06:23
    brondsem

    so I was looking at the recent "rat" failures. it'd be easy to add CHANGES to the ignore file

  • 14:06:35
    brondsem

    I'm not sure what to do with ForgeImporters/forgeimporters/tests/data/google/empty-issue.html and test-issue.html

  • 14:07:16
    brondsem

    it is HTML from google code, used for testing. I have no idea what sort of licensing that would fall under

  • 16:09:08
    tvansteenburgh

    cory_fu, brondsem: in case you didn't see it, i'll need a secondary QA on [#6531]

  • 16:59:32
    tvansteenburgh

    outbound email on our apache instance is working now, just verified my email address

  • 17:01:51
    cory_fu

    tvansteenburgh: I've been thinking it would be nice if get_page took a parse=True/False flag for pages that aren't HTML, like the CSV issues list, so it could use the same caching, etc. shrug

  • 17:03:02
    tvansteenburgh

    i already refactored that :D

  • 17:03:11
    tvansteenburgh
  • 17:03:16
    cory_fu

    I'm reviewing that now

  • 17:04:09
    cory_fu

    You made parse_page overridable, but what if some pages want parsing and some don't? Or two pages use different parsing. I guess that logic still belongs in the subclass

  • 17:04:51
    tvansteenburgh

    yeah, YAGNI. build it when we need it

  • 17:05:51
    cory_fu

    I needed it in the GC tracker importer for the CSV issues list; that is a different format than the rest of the pages, so I had to drop back to urlopen()

  • 17:06:22
    cory_fu

    I guess parse_page can look at self.url or something

  • 17:06:47
    tvansteenburgh

    i see. the most flexible would be to optionally pass in a parser callable to get_page()

  • 17:06:54
    cory_fu

    Yeah

  • 17:07:09
    tvansteenburgh

    i kinda like that idea

  • 17:08:03
    cory_fu

    Yeah

  • 17:08:14
    cory_fu

    Worth adding to the refactors in 6531?

  • 17:08:38
    tvansteenburgh

    sure, why not. who's doing it, you or me?

  • 17:09:52
    cory_fu

    shrug I'm done with 6530 for the moment, so if you're working on something else, I can do it

  • 17:10:07
    cory_fu

    Then we can make Dave review 6531 and then add his changes. :-p

  • 17:10:21
    tvansteenburgh

    lol, that's what i was thinking

  • 17:10:32
    tvansteenburgh

    go for it, i'm working on getting inbound email working on apache instance

  • 17:13:17
    cory_fu

    kk

  • 17:55:52
    tvansteenburgh

    seems like i do in fact to need a different port for inbound email, b/c 25 is already being used for outbound

  • 17:56:19
    tvansteenburgh

    so i can bind that port with our custom handler

  • 17:56:27
    tvansteenburgh

    s/can/cannot/

  • 18:01:26
    ASFBot

    Allura/287: #287 started building, estimated 11 minutes left. https://builds.apache.org/job/allura/287/

  • 18:15:24
    ASFBot

    Allura/287: #287 FAILED after 13 minutes, blame list: dbrondsema https://builds.apache.org/job/allura/287/

  • 18:51:29
    allura-ci-sf

    Project forgehg build #127: STILL FAILING in 2 min 49 sec: http://jenkins.sdot.me/job/forgehg/127/

  • 18:53:15
    allura-ci-sf

    Project forgehg build #128: STILL FAILING in 1 min 48 sec: http://jenkins.sdot.me/job/forgehg/128/

  • 18:56:16
    ASFBot

    Allura/288: #288 started building, estimated 11 minutes left. https://builds.apache.org/job/allura/288/

  • 18:56:16
    ASFBot

    tvansteenburgh: [6595] Clean up tests

  • 19:03:38
    allura-ci-sf

    Yippie, build fixed!

  • 19:03:38
    allura-ci-sf

    Project forgehg build #129: FIXED in 1 min 52 sec: http://jenkins.sdot.me/job/forgehg/129/

  • 19:03:39
    allura-ci-sf

    tvansteenburgh: [allura:tickets:#6595] tarball now requires POST

  • 19:03:51
    allura-ci-sf

    Project allura-rat build #101: STILL FAILING in 7.7 sec: http://jenkins.sdot.me/job/allura-rat/101/

  • 19:08:55
    ASFBot

    Allura/288: #288 built successfully after 12 minutes https://builds.apache.org/job/allura/288/

  • 20:54:15
    cory_fu

    tvansteenburgh: New commit pushed to your tv/6531 branch

  • 20:54:34
    cory_fu

    Want to take a look since brondsem isn't around?

  • 20:55:54
    tvansteenburgh

    sure

  • 20:56:21
    cory_fu

    Hrm. Just noticed that I didn't fix a docstring when I reverted a false-start I made

  • 20:56:37
    cory_fu

    I'll fix the DEFAULT_PARSER bit in get_page's docstring

  • 20:58:38
    cory_fu

    Force-pushed the doc fix

  • 21:02:32
    tvansteenburgh

    extractor = GoogleCodeProjectExtractor(None, url, parser=stringio_parser)

  • 21:03:09
    cory_fu

    Yes?

  • 21:03:26
    tvansteenburgh

    why is parser being passed to init?

  • 21:03:42
    cory_fu

    It gets passed through to get_page

  • 21:04:01
    tvansteenburgh

    oh **kw

  • 21:04:03
    tvansteenburgh

    nvm

  • 21:04:21
    cory_fu

    Just didn't want to type the extra .get_page

  • 21:04:23
    cory_fu

    :-)

  • 21:07:43
    tvansteenburgh

    +1

  • 21:08:26
    tvansteenburgh

    the diff looks good, i did not run the tests b/c i'm in the middle of another ticket

  • 21:09:07
    tvansteenburgh

    if the tests pass, it's good by me