Apache Allura / Chat

Apache Allura / Chat is hosted on FreeNode IRC channel #allura

Log for 2013-06-11

  • 20:10:37
    cory_fu

    So, I'm removing the file size for each commit when viewing the History page of a single file because it can be expensive to compute. Any objections?

  • 20:11:51
    brondsem

    it was a request from a SF project developer

  • 20:12:02
    brondsem

    to be comparable to the viewvc history view

  • 20:12:10
    cory_fu

    Hrm

  • 20:12:39
    cory_fu

    Were they specific about which SCM they wanted it for?

  • 20:12:49
    brondsem

    i think SVN

  • 20:13:21
    brondsem

    git doesn't show it

  • 20:13:25
    brondsem

    gitweb i mean

  • 20:15:56
    cory_fu

    It means making a separate call to pysvn for each commit in the log to get the file size

  • 20:16:23
    brondsem

    viewvc is BSD licensed, you could check to see how they do it

  • 20:27:03
    cory_fu

    Well, they don't use pysvn, for one

  • 20:30:47
    cory_fu

    Ah, they use the python bindings to the SVN binaries, from Apache

  • 20:34:06
    cory_fu

    And they are making a call for each revision to get the file size

  • 20:34:57
    cory_fu

    So I can do the same thing with pysvn.Client.list and tell it to only retrieve the file size. Hopefully it won't be too slow. I'll make sure it's TimerMiddleware'd and we can deal with it if it proves to be an issue

  • 20:35:28
    brondsem

    yeah, I guess i'd lean towards keeping it if we can, but if it's a performance issue it doesn't seem critical to me

  • 21:15:54
    brondsem
  • 21:16:16
    brondsem

    i'm thinking a good solution would be to have a tool setting for git & hg where project admins could set the default branch to use

  • 21:16:59
    brondsem

    it's a rare enough situation I think it's reasonable to have the project admins change the settings. As opposed to some sort of automatic heuristics

  • 21:18:02
    cory_fu

    I would lean toward it just saying that the branch does not exist. The branch list will still show on the left and will be browsable, and you really shouldn't be deleting the default branch in any of the SCMs

  • 21:18:43
    brondsem

    there are a handful of git & hg projects on SF that do it though

  • 21:19:33
    cory_fu

    shrug I guess it's not a big deal either way