Re: [Alephmodular-devel] Preserving/Restoring editor hooks?

[Timothy C. <da...@ma...>]

On Jun 22, 2005, at 12:13 PM, Br'fin wrote:

> Recently I've been reworking the mechanisms that game_wad.cpp uses  
> to load/save files. It has definitely needed work to improve  
> serialization of saved data .
>
> But in the process I've been hacking apart the functions that used  
> to serve as a way for the editor to load a map into the in- 
> application viewer. These functions were already corrupted by the  
> hosting of serialization information.
>
> From what I can determine, the original editor sat as generally  
> separate code and had it's own internal version of process_map_wad 
> (). Where that function in game_wad.cpp handles loading a map from  
> file to memory. The editor's version would already be working with  
> an in memory copy.
>
> This leads me to wonder if I should back out a number of my recent  
> (uncommitted) changes. Rework process_map_wad to translate things  
> into temporary memory and call things like load_point and  
> load_sides with their original arguments, already translated.
>
> I'm strongly inclined to do this as removing the editor functions  
> gets hairier later since aspects here in game_wad are some of the  
> only ones that guide and can manage things like recalculating  
> redundant map information.

Hmm...I have no idea of the nature of these hooks, so...

Would it be possible to ditch them now, and rebuild them in a more  
elegant fashion later, once things stabilize a bit?  Or is the form  
they're in the only form they could take?

If they're becoming a hindrance to what AM is trying to be, then it  
might be best to get rid of them.

I could probably provide more coherent rambling if you could, perhaps  
explain something of what form these hooks take?

Timothy Collett