#2 Write cache files only when necessary

[Stefan Kudwien]

I'm surely not as skilled as you when it comes to programming, but anyway, here's my take on the cache writing issue: it moves the setting of m_bSaveCoverCache to the correct location, to avoid the cache files being unnecessarily written when closing WA.

However, the implemetation might seem a bit strange to you: I've added two Notify*Changed() methods, these could eventually be turned into an oberver. But, as I said, I'm not sure how to do it properly, so I left it quick & dirty for now. Comments always welcome.

Patch is against latest CVS.
--
Stefan

[Stefan Kudwien]

[sap_jr]

Logged In: YES
user_id=855302
Originator: NO

Would love to help test the patch to help see if you can stop winamp hanging on exit when using album list.
.
But!!!!
What is it that you need to do with your patch to get it working?
I use winamp all the time, but im not the most computer literate of people.
:(

[Stefan Kudwien]

Logged In: YES
user_id=348800
Originator: YES

I've uploaded a precompiled binary for you at

http://www.unleashedmind.com/files/gen_m3a-2.07-beta-smk.zip

It ONLY contains Gen_m3a.dll, which must be placed in Program Files\Winamp\Plugins. So, no installer for now, sorry.

***

For developers, and to comply with the GPL, the changed sources are available at

http://www.unleashedmind.com/files/gen_m3a-2.07-beta-smk-src.zip

They have been modified to compile with VS.NET 2005 and contain said cover cache patch, plus a simple patch to free some memory when the Winamp window has been minimized.
--
Stefan Kudwien
http://www.unleashedmind.com

[sap_jr]

Logged In: YES
user_id=855302
Originator: NO

Got it.
I can deal with the plugin dll.
:)
.
For the record.
Its Winamp Version 5.34 im using.
And Album list 2.06
Window XP SP2
P4 2.4
1.75 mem
Radeon 9600pro
terratec dmx 6fire
All running the latest drivers.
.
Ill run this version for a while and get back to you.

[sap_jr]

Logged In: YES
user_id=855302
Originator: NO

OK, here you go.
Ive been running your "fix" for a week or so, and yes it looks like it has stopped all my long waits while winamp shuts down.
It can still have a bit of a wait if ive added new music and it needs to update the cache file, but after that, it works fine again.
.
For your info, ive also been running this fix on my copy of winamp on my games machine.
Winamp Version 5.34
And Album list 2.06
Window XP64 SP1
AMD64 3200+
Radeon 9800Pro
Creative Audigy Platinum Pro
All running the latest drivers.
And it seems to work fine, but ive not used it as much as my main P4 machine.

[sap_jr]

Logged In: YES
user_id=855302
Originator: NO

OK, here you go.
Ive been running your "fix" for a week or so, and yes it looks like it has stopped all my long waits while winamp shuts down.
It can still have a bit of a wait if ive added new music and it needs to update the cache file, but after that, it works fine again.
.
For your info, ive also been running this fix on my copy of winamp on my games machine.
Winamp Version 5.34
And Album list 2.06
Window XP64 SP1
AMD64 3200+
Radeon 9800Pro
Creative Audigy Platinum Pro
All running the latest drivers.
And it seems to work fine, but ive not used it as much as my main P4 machine.

[mugatu69]

Logged In: YES
user_id=1963119
Originator: NO

Hey there,

Thank you for taking the time to solve this annoying problem.

Only, how do I install the patch? there's no download link or information...

10x

B.