Thread: [aKregator-devel] [Bug 261957] New: [Regression] Article list column size isn't remembered
Brought to you by:
lippel
From: Christophe G. <cgi...@gm...> - 2011-01-03 13:47:46
|
https://bugs.kde.org/show_bug.cgi?id=261957 Summary: [Regression] Article list column size isn't remembered Product: akregator Version: SVN Platform: Compiled Sources OS/Version: Linux Status: NEW Severity: normal Priority: NOR Component: general AssignedTo: ag...@kd... ReportedBy: cgi...@gm... CC: akr...@li..., kde...@kd... Created an attachment (id=55519) --> (http://bugs.kde.org/attachment.cgi?id=55519) date column issue The regression appeared with r1207041. The date column cuts the text. See the attached screenshot Any changes to the column width is reverted when changing the active feed. This change reintroduces one of the issues reported in bug 152702 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Aurelien G. <ag...@kd...> - 2011-02-05 09:21:03
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #1 from Aurelien Gateau <agateau kde org> 2011-02-05 10:22:23 --- I put together a simpler version of the code: http://git.reviewboard.kde.org/r/100574/ It does not remember the column widths, but instead tries to ensure all columns get usable default widths: all columns but title are resized to fit their content, the title column gets the remaining width. The title column can still be resized if need be. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Christophe G. <cgi...@gm...> - 2011-02-05 12:26:03
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #2 from Christophe Giboudeaux <cgiboudeaux gmail com> 2011-02-05 13:27:24 --- Created an attachment (id=56889) --> (http://bugs.kde.org/attachment.cgi?id=56889) article list issue With this patch applied, I get a few more issues. See the screenshot attached. With the default window size this is what I get for feeds with unusually long names. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Christophe G. <cgi...@gm...> - 2011-02-05 12:30:14
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #3 from Christophe Giboudeaux <cgiboudeaux gmail com> 2011-02-05 13:31:35 --- Created an attachment (id=56890) --> (http://bugs.kde.org/attachment.cgi?id=56890) another screenshot Another screenshot with a slightly shorter feed name. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Christophe G. <cgi...@gm...> - 2011-02-05 12:35:59
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #4 from Christophe Giboudeaux <cgiboudeaux gmail com> 2011-02-05 13:37:20 --- Created an attachment (id=56891) --> (http://bugs.kde.org/attachment.cgi?id=56891) Usability issue The auto adjusting also introduces a usability issue, Note author column size. Resizing the column is possible but akregator will auto-adjust it again the next time this feed is selected. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Christophe G. <cgi...@gm...> - 2011-02-05 12:49:34
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #5 from Christophe Giboudeaux <cgiboudeaux gmail com> 2011-02-05 13:50:55 --- Created an attachment (id=56894) --> (http://bugs.kde.org/attachment.cgi?id=56894) Date column issue Last issue noticed: When there is no vertical scrollbar, there's an empty area. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Thomas Z. <t....@gm...> - 2011-11-05 20:58:11
|
https://bugs.kde.org/show_bug.cgi?id=261957 Thomas Zell <t....@gm...> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |t....@gm... --- Comment #6 from Thomas Zell <t zell gmx de> 2011-11-05 20:58:03 --- This issue still exists in 4.7.3 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. |
From: Yashin A. <fyn...@ya...> - 2012-05-19 07:19:50
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #7 from Yashin Anton <fyn...@ya...> --- Created attachment 71211 --> https://bugs.kde.org/attachment.cgi?id=71211&action=edit Fix for bug, or workaround. I wrote this patch. It's seems to fix this strange behavior. This behaviour caused: header()->setStretchLastSection( false ); But the line is needed for correct positioning of the columns. Following lines were removed because it set date column size in this path to one pixel: header()->resizeSection( header()->logicalIndex( header()->count() - 1 ), 1 ); Tested on Kubuntu 12.04 with kde 4.8.3 and kdepim 4.8.3 -- You are receiving this mail because: You are on the CC list for the bug. |
From: Allen W. <wi...@kd...> - 2012-05-20 22:01:44
|
https://bugs.kde.org/show_bug.cgi?id=261957 Allen Winter <wi...@kd...> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wi...@kd... --- Comment #8 from Allen Winter <wi...@kd...> --- Yashin, I applied your patch. but now I don't see the Date column at all, except on the feed group lists. what did I miss? -- You are receiving this mail because: You are on the CC list for the bug. |
From: Yashin A. <fyn...@ya...> - 2012-05-23 14:13:18
|
https://bugs.kde.org/show_bug.cgi?id=261957 Yashin Anton <fyn...@ya...> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fyn...@ya... --- Comment #9 from Yashin Anton <fyn...@ya...> --- (In reply to comment #8) > Yashin, > > I applied your patch. but now I don't see the Date column at all, except on > the feed group lists. > > what did I miss? Hi, Allen I get similar behavior during debugging, when present in the functions ArticleListView::setFeedMode() ArticleListView::setGroupMode() of the next line. header()->resizeSection( header()->logicalIndex( header()->count() - 1 ), 1 ); In fact, there is a column with a date, but its width is equal to one pixel. Patched functions must be like this: void ArticleListView::setGroupMode() { if ( m_columnMode == GroupMode ) return; if ( model() ) m_feedHeaderState = header()->saveState(); m_columnMode = GroupMode; restoreHeaderState(); } void ArticleListView::setFeedMode() { if ( m_columnMode == FeedMode ) return; if ( model() ) m_groupHeaderState = header()->saveState(); m_columnMode = FeedMode; restoreHeaderState(); } -- You are receiving this mail because: You are on the CC list for the bug. |
From: Yashin A. <fyn...@ya...> - 2012-05-23 17:29:33
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #10 from Yashin Anton <fyn...@ya...> --- I also removed ArticleListFeedHeaders and ArticleListGroupHeaders from ~/.kde/share/config/akregatorrc -- You are receiving this mail because: You are on the CC list for the bug. |
From: Yashin A. <fyn...@ya...> - 2012-05-23 17:58:18
|
https://bugs.kde.org/show_bug.cgi?id=261957 Yashin Anton <fyn...@ya...> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71211|0 |1 is obsolete| | --- Comment #11 from Yashin Anton <fyn...@ya...> --- Created attachment 71326 --> https://bugs.kde.org/attachment.cgi?id=71326&action=edit fix with saved data upgrade support I think the disappearance of a date column influenced the data stored in the unpatched version. I added an additional check on the width of the column with the date. -- You are receiving this mail because: You are on the CC list for the bug. |
From: Yashin A. <fyn...@ya...> - 2012-05-23 18:16:24
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #12 from Yashin Anton <fyn...@ya...> --- Or you can change the name for the stored data headers (ArticleListFeedHeaders and ArticleListGroupHeaders) in akregatorrc. This will not worry about the compatibility of software with this bug. -- You are receiving this mail because: You are on the CC list for the bug. |
From: Allen W. <wi...@kd...> - 2012-05-25 16:36:00
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #13 from Allen Winter <wi...@kd...> --- Git commit 9345245335b5341bff9de06778652338006fc405 by Allen Winter. Committed on 25/05/2012 at 18:32. Pushed by winterz into branch 'master'. Fix the last column width problems. Yashin, thanks for your work on this. Not resolving the bug yet since we may still want to save/restore column widths. But this patch does improve things. MERGE: 4.8 M +3 -10 akregator/src/articlelistview.cpp http://commits.kde.org/kdepim/9345245335b5341bff9de06778652338006fc405 -- You are receiving this mail because: You are on the CC list for the bug. |
From: Allen W. <wi...@kd...> - 2012-05-25 16:36:39
|
https://bugs.kde.org/show_bug.cgi?id=261957 --- Comment #14 from Allen Winter <wi...@kd...> --- Git commit 167f33cf7642b798b72f743c633b06f5fc343aba by Allen Winter. Committed on 25/05/2012 at 18:32. Pushed by winterz into branch 'KDE/4.8'. Fix the last column width problems. Yashin, thanks for your work on this. Not resolving the bug yet since we may still want to save/restore column widths. But this patch does improve things. MERGE: 4.8 (cherry picked from commit 9345245335b5341bff9de06778652338006fc405) M +3 -10 akregator/src/articlelistview.cpp http://commits.kde.org/kdepim/167f33cf7642b798b72f743c633b06f5fc343aba -- You are receiving this mail because: You are on the CC list for the bug. |