Thread: [aKregator-devel] [Bug 190068] [testcase feed] Akregator crashes when manually fetching a specific (Page 2)
Brought to you by:
lippel
From: Christophe G. <cgi...@gm...> - 2010-09-22 13:26:50
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #23 from Christophe Giboudeaux <cgiboudeaux gmail com> 2010-09-22 15:26:39 --- *** Bug 252008 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Christophe G. <cgi...@gm...> - 2010-09-22 13:26:58
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #24 from Christophe Giboudeaux <cgiboudeaux gmail com> 2010-09-22 15:26:51 --- *** Bug 251716 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Christophe G. <cgi...@gm...> - 2010-09-23 23:45:31
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #25 from Christophe Giboudeaux <cgiboudeaux gmail com> 2010-09-24 01:45:22 --- *** Bug 252101 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Christophe G. <cgi...@gm...> - 2010-09-25 09:49:53
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #26 from Christophe Giboudeaux <cgiboudeaux gmail com> 2010-09-25 11:49:44 --- *** Bug 252310 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Christophe G. <cgi...@gm...> - 2010-10-13 12:03:24
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #27 from Christophe Giboudeaux <cgiboudeaux gmail com> 2010-10-13 14:02:03 --- *** Bug 253964 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Christophe G. <cgi...@gm...> - 2010-10-13 12:06:07
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #28 from Christophe Giboudeaux <cgiboudeaux gmail com> 2010-10-13 14:04:44 --- *** Bug 253130 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
https://bugs.kde.org/show_bug.cgi?id=190068 iva...@gm... changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iva...@gm... --- Comment #29 from <ivan q public gmail com> 2010-11-08 08:58:01 --- I've just recently started to get this same crash. Gonna have to switch to a different feed reader soon, given the severity of the issue and the lack of progress in resolving it. A year and a half, and zero progress? Yikes. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #30 from <ivan q public gmail com> 2010-11-08 11:04:26 --- Ok, I found a specific feed of mine that was causing the crash, and then I whittled it down to a minimal testcase: <?xml version="1.0" encoding="utf-8"?> <feed version="0.3" xmlns="http://purl.org/atom/ns#"> <entry> <content type="xhtml" xml:base="derp"> <div xmlns="derp"></div> </content> </entry> <entry> <content type="xhtml" xml:base="derp"> <div xmlns="derp"></div> </content> </entry> </feed> Why should this cause a crash? I have no idea. To reproduce, save that xml snippet in a file, create a new feed with the appropriate file:// URL, then highlight the new feed and hit F5 several times until you get a crash. Derp. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #31 from <ivan q public gmail com> 2010-11-11 03:34:53 --- Good news, everyone! I used valgrind for the first time, and I tracked this bug down. I'm not a C++ coder, but here's my understanding of what's going on. It's a subtle scoping problem in the function Loader::slotRetrieverDone of libsyndication (kdepimlibs, syndication/loader.cpp). The variable 'src' gets created within the scope of the if statement (line 132) and thus gets automatically destroyed before 'emit loadingComplete(this, feed, status)' happens. This is apparently a problem because 'feed' involves 'src' somehow. Moving and duplicating the 'emit loadingComplete(...)' statement to the ends of both branches of the if statement seems to resolve the problem. However, I still don't know why this bug only rarely caused problems. Perhaps someone with a better knowledge of the source code can comment on that. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-11 07:50:52
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #32 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-11 08:50:08 --- What is the valgrind error you get? I don't see what should be wrong with this code, DocumentSource is not stored in Feed, and if it was, it would be copied (the d pointer handling in there is a bit fishy though and might be buggy). Also, this rather looks like a double deletion of the feed. Well, if your change fixes it, that's definitely worth investigating. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-11 07:54:01
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #33 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-11 08:53:18 --- Ah, hmm. The Feed of course contains dom elements from the QDomDocument created in DocumentSource... -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-11 09:21:57
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #34 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-11 10:21:14 --- I can't reproduce the crash, but I see Invalid reads in valgrind when fetching the feed. Looks indeed like the QDomNodes are deleted twice. Will look into it. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-11 09:46:31
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #35 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-11 10:45:48 --- Created an attachment (id=53316) --> (http://bugs.kde.org/attachment.cgi?id=53316) Patch to fix the bug This patch silences the warnings for me. Please test if it fixes the crash for you. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #36 from <adi cg tuwien ac at> 2010-11-11 17:32:04 --- (In reply to comment #35) > Created an attachment (id=53316) --> (http://bugs.kde.org/attachment.cgi?id=53316) [details] > Patch to fix the bug > > This patch silences the warnings for me. Please test if it fixes the crash for > you. Seems to fix the issue for me... 2 hours without crash and still counting. Thanks Ivan for tracking this down and thanks for the patch. For the records: I am using kdepimlibs 4.4.5-1 from Debian/unstable -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #37 from <ivan q public gmail com> 2010-11-11 21:12:01 --- The patch seems to fix the crash, and it eliminates the invalid reads. Thanks for your quick response. I meant to include more details on the valgrind output, but I was so pleased with my interpretation of it that I forgot. For the record, here's what I was seeing: 5 invalid reads of size 8 in QDomNodePrivate and QDomNodeListPrivate functions, which traced back through Syndication::ElementWrapper::childNodesAsXML() and further back to loader.cpp:157 (the 'emit loadingComplete(...)' statement) The invalid reads were at an address 120 bytes inside a block of size 128 free'd by Syndication::DocumentSource::~DocumentSource(), called from loader.cpp:139 (the end of the if clause) The segfault (when not running in valgrind) traces back to loader.cpp:159 (the 'delete this' statement at the end of Loader::slotRetrieverDone). -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-12 07:12:10
|
https://bugs.kde.org/show_bug.cgi?id=190068 Frank Osterfeld <fra...@kd...> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #38 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-12 08:11:15 --- SVN commit 1195852 by osterfeld: Fix invalid reads (and for some people crashes) when keeping QDomElements around while their QDomDocument is already destroyed. Thanks to ivan.q.public at gmail.com for test input and valgrinding. BUG:190068 M +3 -0 elementwrapper.cpp A tests/atom/bug-190068.xml WebSVN link: http://websvn.kde.org/?view=rev&revision=1195852 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-12 07:13:07
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #39 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-12 08:12:18 --- SVN commit 1195853 by osterfeld: backport 1195852: Fix invalid reads (and for some people crashes) when keeping QDomElements around while their QDomDocument is already destroyed. Thanks to ivan.q.public at gmail.com for test input and valgrinding. BUG:190068 M +3 -0 elementwrapper.cpp A tests/atom/bug-190068.xml WebSVN link: http://websvn.kde.org/?view=rev&revision=1195853 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: Frank O. <fra...@kd...> - 2010-11-12 07:13:41
|
https://bugs.kde.org/show_bug.cgi?id=190068 --- Comment #40 from Frank Osterfeld <frank osterfeld kdemail net> 2010-11-12 08:12:52 --- SVN commit 1195854 by osterfeld: backport 1195852: Fix invalid reads (and for some people crashes) when keeping QDomElements around while their QDomDocument is already destroyed. Thanks to ivan.q.public at gmail.com for test input and valgrinding. BUG:190068 M +3 -0 elementwrapper.cpp A tests/atom/bug-190068.xml WebSVN link: http://websvn.kde.org/?view=rev&revision=1195854 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. |