Thread: [aKregator-devel] Re: [Kde-pim] Proposal: New module "kdepimlibs"
Brought to you by:
lippel
From: Reinhold K. <rei...@ka...> - 2006-04-21 17:39:55
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am Freitag, 21. April 2006 16:51 schrieb Adriaan de Groot: > I see KPilot in that graph. I don't think KPilot exists anymore. Doesn't > simplify the graph much, though. Well, kpilot is stil in svn, you are listed in the MAINTAINERS file, it is still included in the apidox (http://developer.kde.org/documentation/library/cvs-api/kdepim-apidocs/), etc. Do you plan to keep the copy in kdepim up-to-date? Or would it be better to svn mv it, e.g. to kdenonbeta or to extragear? (This would save some work for those that grep through the whole module for Qt4 changes, or who let automated tools run on the whole module, like the one Christoph Bartoschik did). Some other thoughts about our dependencies: 1) wizards does not really depend on korganizer or kmail code-wise, so we might remove these dependencies from the graph. Wizards just configure korganizer and kmail, but for this neither kmail nor korganizer must be installed/compiled. 2) KOrganizer depends on (and links to!!!!!) gpgmepp, simply because libkpimidentities also manages the mPreferredCryptoMessageFormat setting. Just because this one Enum is defined in kleo, korganizer pulls in lots of other dependencies. So my question to the kmail developers: Is there any chance to either get rid of the dependency of libkpimidentities on libkleo, or to move that one setting somewhere else so that korganizer doesn't have to link in all of gpgme? 3) Regarding the unfortunate dependency of kaddressbook on akregator: The only code piece that depends on librss is in kaddressbook/imagewidget.cpp: void ImageBaseWidget::getPictureFromBlog() { if ( mRssLoader ) { return; } mRssLoader = RSS::Loader::create(); connect(mRssLoader,SIGNAL(loadingComplete(Loader*,Document,Status)), SLOT( slotLoadingComplete( Loader *, Document, Status ) ) ); mRssLoader->loadFrom( mBlogFeed, new RSS::FileRetriever ); } void ImageBaseWidget::slotLoadingComplete( RSS::Loader *loader, RSS::Document doc, RSS::Status status ) { if ( status != RSS::Success ) { /* Show error msg loader->errorCode() */ } if ( !doc.image() ) { /* show error msg that blog doesn't contain img */ } blockSignals( true ); mImageUrl->setURL( doc.image()->url().url() ); loadImage(); blockSignals( false ); imageChanged(); mRssLoader = 0; } So my question to the akregator people is whether this can be easily changed to use libsyndication. Or maybe you have a different suggestion to implement this, or another way to get rid of the kaddressbook/ -> akregator/ build dependency. Cheers, Reinhold - -- - ------------------------------------------------------------------ Reinhold Kainhofer, Vienna University of Technology, Austria email: rei...@ka..., http://reinhold.kainhofer.com/ * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/ * K Desktop Environment, http://www.kde.org, KOrganizer maintainer -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFESRi9TqjEwhXvPN0RArvcAJoCTuNytlCT+UFKExVM2rTbW2RcXwCfbOn/ FdTcHf6Oz+xjeOsrgXQaPEw= =Dwl4 -----END PGP SIGNATURE----- |
From: Frank O. <fra...@gm...> - 2006-04-25 19:16:24
|
On Friday 21 April 2006 19:39, Reinhold Kainhofer wrote: > 3) Regarding the unfortunate dependency of kaddressbook on akregator: The > only code piece that depends on librss is in kaddressbook/imagewidget.cpp: > > void ImageBaseWidget::getPictureFromBlog() > { > if ( mRssLoader ) { return; } > mRssLoader =3D RSS::Loader::create(); > connect(mRssLoader,SIGNAL(loadingComplete(Loader*,Document,Status)), > SLOT( slotLoadingComplete( Loader *, Document, Status ) ) ); > mRssLoader->loadFrom( mBlogFeed, new RSS::FileRetriever ); > } > > void ImageBaseWidget::slotLoadingComplete( RSS::Loader *loader, > RSS::Document doc, RSS::Status status ) > { > if ( status !=3D RSS::Success ) { /* Show error msg loader->errorCode()= */ > } if ( !doc.image() ) { /* show error msg that blog doesn't contain img */ > } > > blockSignals( true ); > mImageUrl->setURL( doc.image()->url().url() ); > loadImage(); > blockSignals( false ); > imageChanged(); > > mRssLoader =3D 0; > } > > So my question to the akregator people is whether this can be easily > changed to use libsyndication. Or maybe you have a different suggestion to > implement this, or another way to get rid of the kaddressbook/ -> > akregator/ build dependency. Actually, this piece of code is the only one using our librss fork now -=20 akregator is already ported to libsyndication.=20 It should be easy to port the code above to libsyndication, as it uses libr= ss=20 only for getting the image url but does not use it to actually fetch the=20 image data. (The latter was provided by librss but isn't right now in=20 libsyndication) In the long run, I'd like to have a FeedService daemon plus an akonadi back= end=20 which provide access to feed metadata and items, making direct use of=20 libsyndication unnecessary for application. But for now, it can be simply ported to libsyndication. I will have a look= =20 these days. Regards, =46rank |
From: Frank O. <fra...@gm...> - 2006-04-25 19:22:48
|
On Tuesday 25 April 2006 21:17, Frank Osterfeld wrote: > In the long run, I'd like to have a FeedService daemon plus an akonadi > backend which provide access to feed metadata and items, making direct use > of libsyndication unnecessary for application. > But for now, it can be simply ported to libsyndication. I will have a look > these days. Reading the commits, I see the porting already happened thanks to Volker :-) Frank |