#6 compatibility with mxml 3.0

[Anonymous]

Heyo!
It would be great, if aj-snapshot could be made compatible with mxml 3.0 as soon as possible (which seems to have introduced some changes, but also closes 4 CVEs).
I would like to be able to upgrade the package in the Arch Linux repositories soon.
Please have a look!

As a reference, here's where zynaddsubfx is doing their porting: https://github.com/zynaddsubfx/zynaddsubfx/pull/22
And here yoshimi: https://github.com/Yoshimi/yoshimi/commit/9d5c05b3bb7c87a87f4ddeded9ae30c06bb7eeec

Thanks!

[Anonymous]

For reference, this is basically making it impossible to compile aj-snapshot 0.9.8:

make[1]: Entering directory '/build/aj-snapshot/src/aj-snapshot-0.9.8/src'
gcc -DPACKAGE_NAME=\"aj-snapshot\" -DPACKAGE_TARNAME=\"aj-snapshot\" -DPACKAGE_VERSION=\"0.9.8\" -DPACKAGE_STRING=\"aj-snapshot\ 0.9.8\" -DPACKAGE_BUGREPORT=\"lievenmoors@gmail.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"aj-snapshot\" -DVERSION=\"0.9.8\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBASOUND=1 -DHAVE_LIBJACK=1 -DHAVE_LIBMXML=1 -I.   -D_FORTIFY_SOURCE=2 -Wall -O2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -MT aj-snapshot.o -MD -MP -MF .deps/aj-snapshot.Tpo -c -o aj-snapshot.o aj-snapshot.c
mv -f .deps/aj-snapshot.Tpo .deps/aj-snapshot.Po
gcc -DPACKAGE_NAME=\"aj-snapshot\" -DPACKAGE_TARNAME=\"aj-snapshot\" -DPACKAGE_VERSION=\"0.9.8\" -DPACKAGE_STRING=\"aj-snapshot\ 0.9.8\" -DPACKAGE_BUGREPORT=\"lievenmoors@gmail.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"aj-snapshot\" -DVERSION=\"0.9.8\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBASOUND=1 -DHAVE_LIBJACK=1 -DHAVE_LIBMXML=1 -I.   -D_FORTIFY_SOURCE=2 -Wall -O2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -MT aj-alsa.o -MD -MP -MF .deps/aj-alsa.Tpo -c -o aj-alsa.o aj-alsa.c
mv -f .deps/aj-alsa.Tpo .deps/aj-alsa.Po
gcc -DPACKAGE_NAME=\"aj-snapshot\" -DPACKAGE_TARNAME=\"aj-snapshot\" -DPACKAGE_VERSION=\"0.9.8\" -DPACKAGE_STRING=\"aj-snapshot\ 0.9.8\" -DPACKAGE_BUGREPORT=\"lievenmoors@gmail.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"aj-snapshot\" -DVERSION=\"0.9.8\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBASOUND=1 -DHAVE_LIBJACK=1 -DHAVE_LIBMXML=1 -I.   -D_FORTIFY_SOURCE=2 -Wall -O2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -MT aj-jack.o -MD -MP -MF .deps/aj-jack.Tpo -c -o aj-jack.o aj-jack.c
mv -f .deps/aj-jack.Tpo .deps/aj-jack.Po
gcc -DPACKAGE_NAME=\"aj-snapshot\" -DPACKAGE_TARNAME=\"aj-snapshot\" -DPACKAGE_VERSION=\"0.9.8\" -DPACKAGE_STRING=\"aj-snapshot\ 0.9.8\" -DPACKAGE_BUGREPORT=\"lievenmoors@gmail.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"aj-snapshot\" -DVERSION=\"0.9.8\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBASOUND=1 -DHAVE_LIBJACK=1 -DHAVE_LIBMXML=1 -I.   -D_FORTIFY_SOURCE=2 -Wall -O2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -MT aj-remove.o -MD -MP -MF .deps/aj-remove.Tpo -c -o aj-remove.o aj-remove.c
mv -f .deps/aj-remove.Tpo .deps/aj-remove.Po
gcc -DPACKAGE_NAME=\"aj-snapshot\" -DPACKAGE_TARNAME=\"aj-snapshot\" -DPACKAGE_VERSION=\"0.9.8\" -DPACKAGE_STRING=\"aj-snapshot\ 0.9.8\" -DPACKAGE_BUGREPORT=\"lievenmoors@gmail.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"aj-snapshot\" -DVERSION=\"0.9.8\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBASOUND=1 -DHAVE_LIBJACK=1 -DHAVE_LIBMXML=1 -I.   -D_FORTIFY_SOURCE=2 -Wall -O2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -MT aj-file.o -MD -MP -MF .deps/aj-file.Tpo -c -o aj-file.o aj-file.c
aj-file.c: In function ‘xml_whitespace_cb’:
aj-file.c:25:13: error: dereferencing pointer to incomplete type ‘mxml_node_t’ {aka ‘struct _mxml_node_s’}
  name = node->value.element.name;
             ^~
make[1]: *** [Makefile:366: aj-file.o] Error 1
make[1]: Leaving directory '/build/aj-snapshot/src/aj-snapshot-0.9.8/src'
make: *** [Makefile:342: all-recursive] Error 1

[lieven]

Hi, thanks for reporting. Should be fixed in 0.9.9.
Greetings,
lieven