#58 _:warning: Potential issue_

[Anonymous]

Originally created by: bearycool11
Originally owned by: josefkedwards

          _:warning: Potential issue_

Consolidate HTTP request implementations and fix curl initialization

There are multiple implementations of the httpGet function. Additionally, curl_global_init and curl_global_cleanup are incorrectly called for each request.

1. Remove duplicate implementations and keep only the thread-safe version (lines 534-557)

2. Move curl global initialization/cleanup to application lifecycle:

   :::cpp
   // Add at the top level
   static struct CurlGlobalInit {
   CurlGlobalInit() { curl_global_init(CURL_GLOBAL_DEFAULT); }
   ~CurlGlobalInit() { curl_global_cleanup(); }
   } curlInit;

3. Add SSL/TLS configuration:

   :::cpp
   // Add in httpGet function
   curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 1L);
   curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 2L);
   curl_easy_setopt(curl, CURLOPT_TIMEOUT, 30L);

Also applies to: 256-282, 534-557

_Originally posted by @coderabbitai[bot] in https://github.com/bearycool11/PMLL_logic_loop_Knowledge_block/pull/55#discussion_r1912561032_

[Anonymous]

• assigned_to: josefkedwards