Re: [Aegisvm-devel] patch to jni.c

[Philip F. <pw...@us...>]

Hi Gildas,

I have just processed the part of your JNI patch that has to do with
getting and setting of static and instance fields.  As I mentioned before,
there are enough complexities in the code that I don't feel very 
comfortable maintaining macro-based code template.  So, what I did was
the following:

- Functions ae_jni_[Get|Set]Static[Float|Double]Field are basically manual
  expansion of your macros, with the incorrect references of i8 changed
  back to f8.

- Functions ae_jni_[Get|Set]<Type>Field are basically manual expansion of
  your macros, with the following exceptions:
  - In [Get|Set]DoubleField, the incorrect references of i8 is changed
    back to f8.
  - GetObjectField should wrap the returned value by a local reference.

Attached is that actual patch that I committed, with the following
log:

  New feature: Implementation of [Get|Set]Static[Float|Double]Field and
  [Get|Set]<Type>Field.  Based on a patch contributed by Gildas Bazin
  <gb...@al...>.

I'll work on the last part of your jni patch (i.e. the method invocation
part) now, and when this last bit of your patch is processed, I'll
cut out another new release. :-)

Thank you for your contribution.

Philip
--
Philip W. L. Fong            pw...@us...
The Aegis VM Project         http://aegisvm.sourceforge.net

The Aegis VM Project is an on-going effort to implement a lightweight,
secure JVM.  It will eventually feature a modular architecture, Proof
Linking, that supports pluggable verification modules.