#48 "ael uc" can report competed changes

[Anonymous]

Submitted by Ben Morphett (ben.morphett@silverbrookresearch.com)

There is an interesting inconsistency in "ael uc".

When someone starts to integrate a change, then backs out of integration, then someone else starts to integrate the same change, and completes it, "ael uc" still lists the change, along with all of the other incomplete changes owned by the user. The fact that no other completed changes are listed probably implies that the intent was to list incomplete changes. Below is the list of my changes, with a change clearly marked "completed".

I guess that "ael uc" is confused by the fact that someone else finished the integration, and there are not matching "start integration" and "end integration" records.

A simple sanity check on if the change is in state "completed" might be indicated.

Here is the bug in action:

------------------------------------------

$ ael uc

List of Changes Page 1
Owned by Ben Morphett <bmorphett> Fri Apr 20 16:29:31 2007

Project Change State Description
---------- ------ ---------- -------------
...
qac.1.0 149 completed Initialise 10s after activate
...

$ ael cd 149 -p qac.1.0

Project "qac.1.0", Change 149 Page 1
Change Details Fri Apr 20 16:30:56 2007

NAME
Project "qac.1.0", Delta 151, Change 149,
6d9bcd07-0bc9-4a45-98c4-0561bf1688bd
...
HISTORY
What When Who Comment
------ ------ ----- ---------
new_change Fri Sep 29 spricewh
11:33:19 2006 ite
develop_begin Fri Sep 29 spricewh Elapsed time: 0.798 days.
11:33:19 2006 ite
develop_end Fri Sep 29 spricewh Elapsed time: 0.174 days.
17:32:28 2006 ite
review_pass Fri Sep 29 bmorphet
18:50:51 2006 t
integrate_begin Fri Sep 29 bmorphet Elapsed time: 2.000 days.
18:50:56 2006 t
integrate_ Tue Oct 3 spricewh Elapsed time: 0.074 days.
begin_undo 13:51:29 2006 ite
integrate_begin Tue Oct 3 spricewh Elapsed time: 0.046 days.
14:24:52 2006 ite

integrate_pass Tue Oct 3 spricewh
14:45:22 2006 ite