Menu

#21 Bugfix: Broken LED events

Unstable (example)
closed-fixed
nobody
led (1) bug (1)
5
2015-10-20
2015-10-15
hainet
No

It exists a bug, so that the keyboard LED events are not fired anymore. It seems that this happened due to refactorings. Most of the LED handling is done in video.c. Some parts were left in machine/generic.c. The variable leds_status exists in both files. Changes are stored to the one in generic.c. Firing the LED event is determined by reading the variable content in video.c. Both variables are not connected with each other.

The patch removes the duplicate variable and moves the rest of the LED handling code to video.c. This solves the problem.

Maybe the solution it is clean enough to be included in one of the next builds.
The patch is compatible with stable release of V1.4

1 Attachments

Discussion

  • Andrea Mazzoleni

    Hi hainet,

    Thanks for the patches! I'll have a look at them the next week

    Ciao,
    Andrea

     
  • Andrea Mazzoleni

    Hi hainet,

    I've imported both th patches in the github code.

    Please check if everything is OK.

    Ciao,
    Andrea

     
  • Andrea Mazzoleni

    • status: open --> closed-fixed
     
  • hainet

    hainet - 2015-10-20

    Hi Andrea,

    Thanks for importing! Looks good and works!

    Ciao,
    hainet

     

Log in to post a comment.