Re: [Adobe-source-devel] Begin woes

[Foster T. B. <fbr...@ad...>]

The patch has been applied (it was actually fixed locally and due to  
be released in .12).

Blessings,
Foster

On Dec 30, 2005, at 10:13a, Thomas Witt wrote:

> Sean Parent wrote:
>> I've asked Foster to fix the Save button -
>
> The attached patch fixes the save button semantics. I.e. update  
> file buffer contents before save.
>
> Thomas
>
>
>> Please if you have any reproducible crashes let us know.
>> Sean
>> On Dec 28, 2005, at 3:51 PM, Thomas Witt wrote:
>>>
>>> Hi,
>>>
>>> Just a comment, the current semantics for the save button are   
>>> misleading (well at least to me). Currently the editor contents  
>>> and  the file contents are out of sync unless a successful update  
>>> was  done after the last edit.
>
> -- 
> Thomas Witt
> wi...@ac...
> Index: express_viewer.cpp
> ===================================================================
> RCS file: /cvsroot/adobe-source/adobe-source/adobe/test/begin/ 
> sources/express_viewer.cpp,v
> retrieving revision 1.6
> diff -u -3 -p -u -r1.6 express_viewer.cpp
> --- express_viewer.cpp	2 Dec 2005 02:52:56 -0000	1.6
> +++ express_viewer.cpp	30 Dec 2005 18:10:35 -0000
> @@ -304,9 +304,17 @@ void application_t::_editor_op( adobe::n
>  			display_window();
>  		}
>  		else if ( name == save_adam_name_g )
> -			{ _adam_file_m.save(); }
> +		{
> +      _adam_file_m.set_contents(result.begin(), result.end());
> +
> +      _adam_file_m.save();
> +    }
>  		else if ( name == save_eve_name_g )
> -			{ _eve_file_m.save(); }
> +		{
> +      _eve_file_m.set_contents(result.begin(), result.end());
> +
> +      _eve_file_m.save();
> +    }
>  		else
>  			system_beep(); // unknown request.
>  	}

--
Foster T. Brereton              <}}}><              Romans 3:21-26
A d o b e   S o f t w a r e   T e c h n o l o g y   L a b
"The fact is that the author of STL does not know how to write min,  
the author of C++ is not quite sure, and the standards committee is  
at a loss." -- Alexander Stepanov