Re: [Adobe-source-devel] PATCH: including wrong name header in parser_shared.hpp

[Sean P. <sp...@ad...>]

Hi Ralph,
Thanks for the catch - the correct fix is to #include <adobe/name.hpp> 
in parser_shared.cpp (we try to stick to only forward includes in the 
headers - this issue with name_t hadn't come up, I'll think about it to 
see if I can find a way to handle it that will show the error more 
readily in the future).

I checked in a fix on our side to our perforce depot - I'll have Foster 
roll it into CVS.

Thanks for the updated instructions also! - we'll incorporate it into a 
building ASL page (we have such a page internally, it hadn't come up 
yet for the open source release).

Sean

On Mar 14, 2005, at 8:24 PM, Ralph Thomas wrote:

> Hi folks,
>
>   I tried using ASL on Linux/x86, with GCC 3.2.3. I couldn't link a
> release build of the adam tutorial (after I'd removed the call to
> adam_t::inspect, which is only available in debug builds), because
> parser_shared.o didn't know that name_t::get was inline. Changing the
> name_t header file which parser_shared.hpp includes fixes the problem
> (oddly enough a debug build compiles and links fine without the change
> -- maybe debug turns off inlining).
>
>   I didn't see any instructions on how to make a build (perhaps I
> didn't look hard enough -- I ended up reading the shell script which
> checks the code out of boxer.corp...), so I wrote a brief list:
>
>   http://www.infinite-imagination.com/software/asl/
>
> Thanks,
>  Ralph
>
>> c_rdiff parser_shared.hpp
> Index: parser_shared.hpp
> ===================================================================
> RCS file: 
> /cvsroot/adobe-source/adobe-source/adobe/source/parser_shared.hpp,v
> retrieving revision 1.2
> diff -r1.2 parser_shared.hpp
> 15c15
> < #include <adobe/name_fwd.hpp>
> ---
>> #include <adobe/name.hpp>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real 
> users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Adobe-source-devel mailing list
> Ado...@li...
> https://lists.sourceforge.net/lists/listinfo/adobe-source-devel