adobe-source-devel

[Adobe-source-devel] PATCH: including wrong name header in parser_shared.hpp

[Ralph T. <ra...@gm...>]

Hi folks,

  I tried using ASL on Linux/x86, with GCC 3.2.3. I couldn't link a
release build of the adam tutorial (after I'd removed the call to
adam_t::inspect, which is only available in debug builds), because
parser_shared.o didn't know that name_t::get was inline. Changing the
name_t header file which parser_shared.hpp includes fixes the problem
(oddly enough a debug build compiles and links fine without the change
-- maybe debug turns off inlining).

  I didn't see any instructions on how to make a build (perhaps I
didn't look hard enough -- I ended up reading the shell script which
checks the code out of boxer.corp...), so I wrote a brief list:

  http://www.infinite-imagination.com/software/asl/

Thanks,
 Ralph

> c_rdiff parser_shared.hpp 
Index: parser_shared.hpp
===================================================================
RCS file: /cvsroot/adobe-source/adobe-source/adobe/source/parser_shared.hpp,v
retrieving revision 1.2
diff -r1.2 parser_shared.hpp
15c15
< #include <adobe/name_fwd.hpp>
---
> #include <adobe/name.hpp>

Re: [Adobe-source-devel] PATCH: including wrong name header in parser_shared.hpp

[Sean P. <sp...@ad...>]

Hi Ralph,
Thanks for the catch - the correct fix is to #include <adobe/name.hpp> 
in parser_shared.cpp (we try to stick to only forward includes in the 
headers - this issue with name_t hadn't come up, I'll think about it to 
see if I can find a way to handle it that will show the error more 
readily in the future).

I checked in a fix on our side to our perforce depot - I'll have Foster 
roll it into CVS.

Thanks for the updated instructions also! - we'll incorporate it into a 
building ASL page (we have such a page internally, it hadn't come up 
yet for the open source release).

Sean

On Mar 14, 2005, at 8:24 PM, Ralph Thomas wrote:

> Hi folks,
>
>   I tried using ASL on Linux/x86, with GCC 3.2.3. I couldn't link a
> release build of the adam tutorial (after I'd removed the call to
> adam_t::inspect, which is only available in debug builds), because
> parser_shared.o didn't know that name_t::get was inline. Changing the
> name_t header file which parser_shared.hpp includes fixes the problem
> (oddly enough a debug build compiles and links fine without the change
> -- maybe debug turns off inlining).
>
>   I didn't see any instructions on how to make a build (perhaps I
> didn't look hard enough -- I ended up reading the shell script which
> checks the code out of boxer.corp...), so I wrote a brief list:
>
>   http://www.infinite-imagination.com/software/asl/
>
> Thanks,
>  Ralph
>
>> c_rdiff parser_shared.hpp
> Index: parser_shared.hpp
> ===================================================================
> RCS file: 
> /cvsroot/adobe-source/adobe-source/adobe/source/parser_shared.hpp,v
> retrieving revision 1.2
> diff -r1.2 parser_shared.hpp
> 15c15
> < #include <adobe/name_fwd.hpp>
> ---
>> #include <adobe/name.hpp>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real 
> users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Adobe-source-devel mailing list
> Ado...@li...
> https://lists.sourceforge.net/lists/listinfo/adobe-source-devel

Re: [Adobe-source-devel] PATCH: including wrong name header in parser_shared.hpp

[Ralph T. <ra...@gm...>]

Great!

I also had to make some changes to the adam_tutorial Jamfile to make
it build on Win32/MSVC7.1... I don't think that the
BOOST_THREAD_USE_LIB is really correct, but without it the link fails
because some symbols don't get exported (for some other reason, _DLL
is defined and this makes boost.thread think that it should do symbol
hiding).

Thanks,
 Ralph

Index: adobe/test/adam_tutorial/Jamfile
===================================================================
RCS file: /cvsroot/adobe-source/adobe-source/adobe/test/adam_tutorial/Jamfile,v
retrieving revision 1.1
diff -u -r1.1 Jamfile
--- adobe/test/adam_tutorial/Jamfile	7 Mar 2005 07:28:36 -0000	1.1
+++ adobe/test/adam_tutorial/Jamfile	15 Mar 2005 08:49:50 -0000
@@ -43,5 +43,6 @@
 		../../../third_party/boost_tp/boost/libs/thread/src/exceptions.cpp 
 		../../../third_party/boost_tp/boost/libs/thread/src/mutex.cpp 
 		../../../third_party/boost_tp/boost/libs/thread/src/once.cpp
-	:	<define>ADOBE_SERIALIZATION
+		../../../third_party/boost_tp/boost/libs/thread/src/xtime.cpp
+	:	<define>ADOBE_SERIALIZATION <define>BOOST_ALL_NO_LIB=1
<define>BOOST_THREAD_USE_LIB
 	;

On Mon, 14 Mar 2005 21:31:06 -0800, Sean Parent <sp...@ad...> wrote:
> Hi Ralph,
> Thanks for the catch - the correct fix is to #include <adobe/name.hpp>
> in parser_shared.cpp (we try to stick to only forward includes in the
> headers - this issue with name_t hadn't come up, I'll think about it to
> see if I can find a way to handle it that will show the error more
> readily in the future).
> 
> I checked in a fix on our side to our perforce depot - I'll have Foster
> roll it into CVS.
> 
> Thanks for the updated instructions also! - we'll incorporate it into a
> building ASL page (we have such a page internally, it hadn't come up
> yet for the open source release).
> 
> Sean
> 
> On Mar 14, 2005, at 8:24 PM, Ralph Thomas wrote:
> 
> > Hi folks,
> >
> >   I tried using ASL on Linux/x86, with GCC 3.2.3. I couldn't link a
> > release build of the adam tutorial (after I'd removed the call to
> > adam_t::inspect, which is only available in debug builds), because
> > parser_shared.o didn't know that name_t::get was inline. Changing the
> > name_t header file which parser_shared.hpp includes fixes the problem
> > (oddly enough a debug build compiles and links fine without the change
> > -- maybe debug turns off inlining).
> >
> >   I didn't see any instructions on how to make a build (perhaps I
> > didn't look hard enough -- I ended up reading the shell script which
> > checks the code out of boxer.corp...), so I wrote a brief list:
> >
> >   http://www.infinite-imagination.com/software/asl/
> >
> > Thanks,
> >  Ralph
> >
> >> c_rdiff parser_shared.hpp
> > Index: parser_shared.hpp
> > ===================================================================
> > RCS file:
> > /cvsroot/adobe-source/adobe-source/adobe/source/parser_shared.hpp,v
> > retrieving revision 1.2
> > diff -r1.2 parser_shared.hpp
> > 15c15
> > < #include <adobe/name_fwd.hpp>
> > ---
> >> #include <adobe/name.hpp>
> >
> >

Re: [Adobe-source-devel] PATCH: including wrong name header in parser_shared.hpp

[Niki S. <nik...@gm...>]

===================================================================
> RCS file: /cvsroot/adobe-source/adobe-source/adobe/test/adam_tutorial/Jamfile,v
> retrieving revision 1.1
> diff -u -r1.1 Jamfile
> --- adobe/test/adam_tutorial/Jamfile    7 Mar 2005 07:28:36 -0000       1.1
> +++ adobe/test/adam_tutorial/Jamfile    15 Mar 2005 08:49:50 -0000
> @@ -43,5 +43,6 @@
>                 ../../../third_party/boost_tp/boost/libs/thread/src/exceptions.cpp
>                 ../../../third_party/boost_tp/boost/libs/thread/src/mutex.cpp
>                 ../../../third_party/boost_tp/boost/libs/thread/src/once.cpp
> -       :       <define>ADOBE_SERIALIZATION
> +               ../../../third_party/boost_tp/boost/libs/thread/src/xtime.cpp
> +       :       <define>ADOBE_SERIALIZATION <define>BOOST_ALL_NO_LIB=1
> <define>BOOST_THREAD_USE_LIB
>         ;

FYI this works for mingw too.

Niki Spahiev