Menu

#468 composer will not provide "externals" dependencies

Git
closed-wont-fix
nobody
5
2018-01-23
2015-08-31
Bart Reunes
No

After requiring "vrana/adminer" with composer, the compile.php script will complain that the gitmodules in externals are not found. Composer is not resolving these dependencies. Could it be possible to make those dependencies available through composer, or add them to the composer file that is provided in the main project?

Discussion

  • Bart Reunes

    Bart Reunes - 2015-09-25

    Do you need some extra information for this? Anything I should check?

     
  • AlberT

    AlberT - 2016-05-27

    I'm encountering the same issue ..

    I suggest to avoid use of subpackages, as they are not necessary using composer.
    Please make this packages a requirement in composer.json .. at the moment it seems hard to use adminer as a custom project dependancy

    Thank you in advance

    PS:
    just for reference. A workaround until this issue will be fixed can be the following code in composer.json of your application:

    "repositories": [
    {
                "type": "package",
                "package": {
                    "name": "vrana/adminer",
                    "version": "4.2.4",
                    "dist": {
                        "url": "https://www.adminer.org/static/download/4.2.4/adminer-4.2.4.php",
                        "type": "file"
                    },
                    "source": {
                        "url": "https://github.com/vrana/adminer",
                        "type": "git",
                        "reference": "releases/tag/v4.2.4"
                    }
                }
            }
    ]
    
     

    Last edit: AlberT 2016-05-27
  • Jakub Vrána

    Jakub Vrána - 2017-02-20
    • status: open --> closed-wont-fix
     
  • Jakub Vrána

    Jakub Vrána - 2017-02-20

    Supporting .gitmodules by Composer seems like the better thing to do.

     
  • pimcore-builds

    pimcore-builds - 2017-08-14

    Well, that's not really a solution, .gitmodules is still not supported by Composer.
    If this isn't getting fixed, the composer.json should be removed as this package isn't function properly without the external dependencies.

     
  • Jakub Vrána

    Jakub Vrána - 2018-01-23

    Adminer works quite OK even without dependencies present. Syntax highlighting doesn't work and JS minification doesn't but that's about it.

    Is there a way how to make Composer work and keeping the submodules? Please send me a pull request.

     

Log in to post a comment.

MongoDB Logo MongoDB