#54 Reducing binary by removing jars

open
5
2009-05-13
2009-05-13
No

I checked from Eclipse and the following when removed gives ok in compile. I will test with build later. WDYT?

<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/activation.jar"/> -
<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/commons-beanutils-1.7.0.jar"/>
<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/commons-collections.jar"/>
<classpathentry kind="lib" path="zkwebui/WEB-INF/lib/bsh.jar"/>
<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/commons-digester.jar"/>
<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/commons-lang-2.3.jar"/>
<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/commons-fileupload.jar"/>
<classpathentry kind="lib" path="zkwebui/WEB-INF/lib/commons-fileupload.jar"/>
<classpathentry kind="lib" path="zkwebui/WEB-INF/lib/jython.jar"/>
<classpathentry kind="lib" path="posterita/posterita/web/WEB-INF/lib/commons-logging.jar"/>

Discussion

  • Carlos Ruiz

    Carlos Ruiz - 2009-05-13

    Hi Redhuan, not sure and I don't have time to test.

    I think that removing
    zkwebui/WEB-INF/lib/bsh.jar
    zkwebui/WEB-INF/lib/jython.jar
    Will break the scripting functionality in zk.
    Can you please test that?
    All the scripting family is linked in my page http://www.adempiere.com/index.php/User:CarlosRuiz

    Also, I don't know the collateral effects of removing:
    zkwebui/WEB-INF/lib/commons-fileupload.jar
    given the name (fileupload), have you tested uploading files via attachment, or import file loader, or initial client setup ...

    Please note that "compile ok" is not enough here - functionalities must be tested.

    Regards,

    Carlos Ruiz

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2009-05-13

    Hi Heng Sin,
    After both commits until Revision: 9263, I conducted the following tests all successfully:

    1) In Eclipse, refresh - no compile errors;

    2) RUN_build.sh - completed successfully

    3) Update trunk to local - run ant at migration/353a-trunk/posterita - successful

    4) Remove old binary and deploy new binary

    5) RUN_setup.sh - successful

    6) RUN_Server2.sh - successful

    7) Launch both Java and web client

    8) Select Posterita and login - successful till Cashier screen

    9) Select ZKAjax - successful display

    9.1) Drag panels around - successful

    9.2) Launch few items from Accounts Viewer to Sales Order

    9.3) At Sales Order noted that Master Detail setup from previous instance still intact

    9.4) Created new Sales Order and right click at Bpartner for new record - successful creation and resume to SO

    9.5) Created new OrderLine pop-up to Locator selection for 1 item - Rake Metal

    9.6) Complete at main tab, press complete, done

    10) Via Java Client, view done SO - as expected.

    Will stop removal of further jars to cool off these commits. I am not 100% confident to continue until you say so.

    Thank you for your kind attention and Regards,
    red1

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2009-05-13
    • assigned_to: nobody --> red1
     
  • Heng Sin

    Heng Sin - 2009-05-13

    Hi Redhuan,

    I'm not sure about posterita web pos, for zk client, carlos already point out the test you need to carry out. for e.g, try upload a file to sales order using the attachment dialog.

    Regards,
    Low

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2009-05-13

    Carlos... Hengsin... Ok will do that now..

     
  • Carlos Ruiz

    Carlos Ruiz - 2009-05-13

    Hi Redhuan,

    > 9) Select ZKAjax - successful display

    not enough - as I wrote you need to check the scripting family as you removed the jars of the script languages.

    Also you need to check uploading files as you removed a jar called fileupload something.

    Also I see you removed some sources - I think they don't affect the size of the binary release - and most of zkwebui jar doesn't affect the size of the adempiere jar client.

    I think you better revert the two commits related to this.
    Unfortunately every jar needs to be checked.

    I would prefer to think on removing duplicate jars.

    [ Wow - I was writing this in sourceforge and your messages appeared magically below my comments box - this new ajax sourceforge looks great - and lately I've experienced a improvement on the speed of sf ]

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz

    Carlos Ruiz - 2009-05-13
    • assigned_to: red1 --> nobody
     
  • Redhuan D. Oon

    Redhuan D. Oon - 2009-05-13

    Yes Carlos.. while i was reading your comment, Heng Sin's comment also magically appeared. And SF seems back to normal for me too.

    Will test your suggestions now.. and feedback immediately

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2009-05-13
    • assigned_to: nobody --> red1
     
  • Redhuan D. Oon

    Redhuan D. Oon - 2009-05-13

    Confirmed error as you advised --> ERROR [STDERR] -----------> zkoss.init:174: Failed to configure fileupload. Make sure commons-fileupload.jar is installed.

    will revert that in my instance and test further.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks