Menu ▾ ▴

#10 readGGA: incorrect conversion of lat/lon, silent fail for empty message fields

New
Karl Kastner
None
High
Defect
2016-12-07
2016-12-07
Karl Kastner
No

1.) The fractional part of lat and lon is divided by 60. This looks like a copy and paste bug from the time conversion. The fractional part of lat and lon in the GGA command string are true decimals, not seconds.

2.) Reading of lat and lon is incomplete if the GGA coordinate string is empty, i.e. if there is no value between any pair of delimiting commas. In such a case the parsing is silently stopped at the first GGA command that has an empty coordinate string.

Discussion

  • Karl Kastner

    Karl Kastner - 2016-12-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,3 @@
-1.) The fractional part of lat and lon is devided by 60. This looks like a copy and paste bug from the time conversion. The fractional part of lat and lon in the GGA command string are true decimals, not seconds.
+1.) The fractional part of lat and lon is divided by 60. This looks like a copy and paste bug from the time conversion. The fractional part of lat and lon in the GGA command string are true decimals, not seconds.

 2.) Reading of lat and lon is incomplete if the GGA coordinate string is empty, i.e. if there is no value between any pair of delimiting commas. In such a case the parsing is silently stopped at the first GGA command that has an empty coordinate string.
     

  • Karl Kastner

    Karl Kastner - 2016-12-07

    The conversion was correct, but the empty string problem was real. I added a comment on the conversion, because it is not obvious at a first glance.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.