Re: [Acx100-devel] commit: mac80211 api changes for 3.8 has a problem

[Oliver W. <oli...@ol...>]

Hi Hauke,

Indeed, you're probably right ;)! I didn't test either yet
(for one time) and actually wanted to do that the weekend.

I'll check the fix and push it soon then, and also look at the 
other patches you sent.

Thanks a lot for notifying!

Best Regards, Oliver

On Thu, 03 Jan 2013 14:36:09 +0100
Hauke Mehrtens <ha...@ha...> wrote:

> Hi Oliver,
> 
> I just saw your commit:
> 
> commit cc9cc94298fb18809852c6e72f6d51a7f92bc58f
> Author: Oliver Winker <ol...@ol...>
> Date:   Wed Jan 2 20:47:06 2013 +0100
> 
>     main: mac80211 api changes for 3.8
> 
> and I think it is wrong.
> 
> This was done to adapt the changes done in:
> 
> commit b9a9ada14aab17f08c1d9735601f1097cdcfc6de
> Author: Johannes Berg <joh...@in...>
> Date:   Thu Nov 29 13:00:10 2012 +0100
> 
>     mac80211: remove probe response temporary buffer allocation
> 
>     Instead of allocating a temporary buffer to build IEs
>     build them right into the SKB.
> 
>     Signed-off-by: Johannes Berg <joh...@in...>
> 
> The memcpy was removed from mac80211 code and should now be done in
> the driver, at least it is done so in all the drivers affected by this
> commit. Could you add something like this:
> 
>        if (req->ie_len)
>                memcpy(skb_put(skb, req->ie_len), req->ie,
> req->ie_len);
> 
> I do not have the hardware at hand to test this.
> 
> Hauke
> 
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills
> current with LearnDevNow - 3,200 step-by-step video tutorials by
> Microsoft MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> _______________________________________________
> Acx100-devel mailing list
> Acx...@li...
> https://lists.sourceforge.net/lists/listinfo/acx100-devel
>