From: Jim C. <jim...@gm...> - 2012-04-09 08:49:41
|
hi Oliver, This reworks 1-10 sent previously, and adds a bunch more. - now using pr_notice, not pr_debug (patch 3). This gives one place to uniformly set (or change later) the all log message prefixes (via pr_fmt), and avoids feature/compatibility issues with pr_debug() on older kernels. Patches 4,5 strip the hard-coded prefixes now added by pr_fmt(). - usb.h: USB=n problems were user error; toggling wrong part of Makefile flags, and using #if FOO not CONFIG_FOO. I think the subset (paches 9-15) is still a net gain wrt partioning and cleanliness. You may want to squash some of them together; 10-13, and 14,15. Or drop them for now. - add .gitignore - drop VEC_SIZE for ARRAY_SIZE - C99 style array initialization - BUILD_BUG_DECL to enforce same size of 2 arrays - kzalloc - move kmalloc into eeprom readers, where size is known. - a few todos - a whitespace, style, linewrap patch (at end so its easy to drop) Other than the groupings mentioned, it should be ok to drop any (ie no dependencies) that you dont want now (or at all). thanks ~jimc |