From: <mr...@se...> - 2003-08-03 18:32:47
|
Hi The following patch: *** acx100/src/acx100.c 2003-07-27 22:48:50.000000000 +0200 --- acx100.test/src/acx100.c 2003-08-03 19:35:26.000000000 +0200 *************** *** 818,823 **** --- 818,828 ---- txresult = dmaTxData(wlandev, pb); if (txresult == 1){ // acx100_unlock(wlandev,&flags); + if (pb->p80211hostbuf != NULL) + kfree(pb->p80211hostbuf); + + if (pb != NULL) + kfree(pb); return 1; } acxlog(L_XFER, "wake queue for future Tx.\n"); fixes big memory leak in function acx100_start_xmit - memory leaks after unsuccesfull call to dmaTxData (when ring buffer is full). It happends quite often during big transfers beetwen wired lan and wireless lan or ping floods, every time when "Can't send packet, no txdesc free (yet)!" message appears in debug log. I have been tested this patch little (sending huge amounts of data) - everything seems to be ok. Please include this patch in next driver release, if possible. -- mrk(at)sed.pl |
From: Benjamin S. <bsc...@el...> - 2003-08-04 07:05:02
|
> Please include this patch in next driver release, if possible. I think this patch became obsolete since Jef replaced the buffer handling completely. Sorry, but thank anyway. Benjamin. |
From: <mr...@se...> - 2003-08-04 12:12:21
|
>> Please include this patch in next driver release, if possible. > > I think this patch became obsolete since Jef replaced the buffer > handling completely. Sorry, but thank anyway. > OK. When can we expect next driver release with better buffer handling ? mrk |
From: Benjamin S. <bsc...@el...> - 2003-08-05 14:51:28
|
Hi, > OK. When can we expect next driver release with better buffer handling ? Pretty soon. Many new features have been added and need proper testing before we can release. But it will be available in a few days. Benjamin. |
From: Andreas M. <an...@rh...> - 2003-08-05 15:05:29
|
On Tue, Aug 05, 2003 at 04:46:29PM +0200, Benjamin Schrauwen wrote: > Hi, > > > OK. When can we expect next driver release with better buffer handling ? > > Pretty soon. Many new features have been added and need proper testing > before we can release. But it will be available in a few days. OK, I think now is a good time to ask people to stop doing "new" "crazy" things ;) With state management and new packet core code, we have a lot to test now (and it should be relatively easy to handle, hopefully), so please don't add more experimental code now. -- Help prevent Information Technology Fascism! - before it's too late... http://www.againsttcpa.com |