[Actionframework-users] two bug fix patches

[Mark D. A. <md...@di...>]

This is relative to the 0.94.2 release sources.

The first diff takes care of a spurious MalformedURLException when
running under https, at least for some container environments.

The 2nd and 3rd diffs stop doing a toString() on the return values
of action methods. Even if the debug argument isn't used, it is
very expensive to compute toString() on some objects, such as
List objects with many elements which themselves have large
toString values.

-mda

src/org/actionframework/ActionServlet.java
356c356,359
<                 context.put("URL", new URL(request.getScheme(),
request.getServerName(),
---
>               // mda: deal with java.net.URL not always handling https scheme (because no URLStreamHandlerFactory).
>               String scheme = request.getScheme();
>               if (scheme != null && scheme.equals("https")) scheme = "http";
>                 context.put("URL", new URL(scheme, request.getServerName(),


src/org/actionframework/runtime/Action.java
837c837,839
<             actionReqData.log.debug("Return value '" +
onReturnCompareValue + "' matched by " +
---
>           //mda
>             //actionReqData.log.debug("Return value '" + onReturnCompareValue + "' matched by " +
>           actionReqData.log.debug("Return value matched by " +


src/org/actionframework/OnReturnData.java
117a118
>           // mda: don't waste effort on retValue.toString
121a123
>                                          /*
123a126,127
>                                          */
>                                          "Assigning return value of type {" +