Re: [Actionframework-users] ActionConfigEntityResolver.java is worse than doing nothing

[Petr T. <Pet...@pi...>]

> ActionConfigEntityResolver.java is severely broken:

There's been only 1 line added to ActionConfigEntityResolver.java:
dtds.put(PATH + "ActionServlet_0_94beta.dtd", "ActionServlet_0_94beta.dtd");
 
> 1. It assumes that it will only be called for external entities that are
> DTD's, which prevents other kinds of external entities.
> It reports an error and returns null if systemId does not appear in its
> fixed list.

I think I tried SYSTEM !DOCTYPE path like: file:///home/~user/my.dtd. Could you
please send me an example of dtd or something that refers non-dtd external
entitiy, so we can fix this?
 
> 2. Even if it is a DTD, it does something which can't possibly work,
> which is getClass().getResourceAsStream("/dtd/" + DTD). This can't work
> both because the Class may not be the same as the application servlet 
> instance, and because the variable DTD is set to an http url elsewhere 
> in the code.

getClass().getResourceAsStream("/dtd/" + DTD) loads DTDs from the 'dtd' folder
in ActionServlet.jar, so it prevents network calls. It works for me with Tomcat
3/4 and JSDK 2.0. What problems do you have?

Regards,
Petr
[ http://dione.zcu.cz/~toman40 - Pet...@pi... - ICQ=22957959 ]