Re: [Actionframework-users] also velocity requestCleanup
Status: Inactive
Brought to you by:
ptoman
From: Mark D. A. <md...@di...> - 2002-10-05 20:52:06
|
> I think that overriding error() in VelocityServlet where > ActionServlet.error(Context, String, Throwable) would be called is > suitable [plus adding this method to AS as you suggested]. I'm in dire need for this change, because my servlet won't function properly without it: it can't properly decide upon commit vs. rollback of my per-request transaction. As I mentioned, ActionServlet.cleanupRequest() is of no use because it is in a finally clause and always gets run. Velocity's requestCleanup() is more useful for doing a transaction commit(), but it is hidden from me by AS. If AS exposes everything sent to Velocity's error(), then I can probably trust it is safe to do a commit. In addition, AS might override Velocity's requestCleanup and expose that in its servlet, perhaps under the name "requestSuccessful" or "noException" or something. Will you be releasing a version with the error() override in the next week or so, or should I go ahead and write a patch of my own? -mda |