Re: [Actionframework-users] also velocity requestCleanup
Status: Inactive
Brought to you by:
ptoman
From: Petr T. <Pet...@pi...> - 2002-09-30 16:02:00
|
> AS's VelocityServlet should also override Velocity's > VelocityServlet.requestCleanup > > As with error(), because AS's VelocityServlet is not hooking those, I > am left with no access to those. There is a big difference between > velocity's requestCleanup and ActionServlet's cleanupRequest, because > cleanupRequest is in a finally, whereas velocity's requestCleanup is > only called if no exception was thrown. > > In combination, the fact that neither are available to users of > ActionServlet is that I have no easy way to determine whether request > processing was even successful. Let's discuss where could an error ocurr and how to handle it: - error in action method -> handled by <on-exception> or onException() - in template -> exception is propagated from handle() - in onException() & co. -> exception is propagated from handle() So, I think that you may just catch Throwable in overridden handle() method - and VelocityServlet.requestCleanup() is not needed. Petr -- [ http://dione.zcu.cz/~toman40 - Pet...@pi... - ICQ=22957959 ] |