Re: [Actionframework-users] bug in ActionServlet ActionRuntime.java

[Petr T. <Pet...@pi...>]

 > in ActionRuntime.java there is this line: actionConfigFile = new
 > File(servlet.getClass().getResource("/" + configFilename).getFile());
 >
 >
 > which will give NullPointerException if getResource fails (remember
 > getResource just returns null on failure; it does not throw an
 > exception).

Yep, I know about this - will be fixed in the next release, but thanks
for bugreport anyway. Here's what I have fixed already:

- bugfix: misleading unexpected initialization error was reported when
           ActionConfig was not found
- bugfix: <in/output-variable> evaluated to null on false "if" condition
           even if some value had been retreived from the request or URL
- bugfix: <in/output-variable name="v1" value="$v2"/>s copied always
           $v2 as String
- bugfix: parameter retreiving didn't work for <invoke> in some cases
- bugfix: composite type definition was not checked against null
- bugfix: SendReceive demo functionality was broken

 > btw, in order to get the velocity conversion to work, this will work
 > in build.xml as an alternative to mucking with the ant installation:
 >
 > <taskdef name="templateConvertor"
 > classname="org.actionframework.engines.velocity.convert.TemplateConve-
 > rtorAntTask"> <classpath> <pathelement
 > location="lib/TemplateConvertor.jar"/> <pathelement
 > location="${Velocity.home}/velocity-1.3.1-rc2.jar"/> <pathelement
 > location="lib/jakarta-oro-2.0.5.jar"/> </classpath> </taskdef>

Good idea. Will be there.

 > Speaking of Velocity.home, I think it'd be easier in build.xml and
 > build.properties to just ask for Velocity.jar or Velocity.classpath,
 > rather than hardcoding assumptions about the jar file name. I had to
 > edit build.xml to make ugly things like this: <available
 > file="${Velocity.home}/velocity-1.3.1-rc2.jar"
 > property="Velocity.All"/> <available
 > file="${Velocity.home}/velocity-1.2.jar" property="Velocity.All"/>
 > <available file="${Velocity.home}/velocity-1.1.jar"
 > property="Velocity.All"/> just to get it to run with my recent
 > version of velocity.

Agreed. Thanks for suggestions!

-Petr
PS: http://www.actionframework.org is working finally! :)
-- 
[ http://dione.zcu.cz/~toman40 - Pet...@pi... - ICQ=22957959 ]