Something similar happens for me (see attached log). I have Java 1.8 and Java 17 installed, and the "PATH" environment variable has entries "C:\Program Files\Common Files\Oracle\Java\javapath" (contains Java 17 exe files) and "C:\Program Files (x86)\Common Files\Oracle\Java\javapath" (seems to contain Java 1.8 files). The Java 17 entry is before the Java 1.8 entry. But ACT.exeseems to use Java 1.8. where java.exe C:\Program Files\Common Files\Oracle\Java\javapath\java.exe C:\Program Files (x86)\Common...
How about a github project - with a "how to develop" guide ;-)? Best regards Wolfgang
Thanks! Last year I went the long road to convert all my CDs to MP3 and "coverize" them all. So there was a motivation to let ACT do most of the job. As I am done with this big batch job, there are only a few new CDs per year. And here I can download the highest quality cover myself ;-). So, it is great if you apply my suggestions, but it is impossible to reach a 100% rate for ACT - it cannot decide about the cover scan quality. Best regards Wolfgang
I just uploaded v1.5.0 and i have tested it with Windows 10 and Java 17 (but should run with Java 11 also).
.classpath and .project files are not recommend to include in source package (compiler warning). Both can be (re)created by process of import. Having the "Eclipse RCP" features/plugins installed you can import the source tree as project via "Import -> Plug-in Development -> ..."
Unfortunately the same thing happens with Java 11.
You are using Java8, but Java11 is required!
After a long delay... Inspecting the list of your issues in this thread: * The tracklist in 'master' is often different from them in 'release', so simply preferring 'master' over 'release' is not the solution. But where you are right: 'master' is one more valid source for album informations. So 'master' is is now also selected in addition to 'release' and will have a good chance to become the matching album source, because is selected as first... and handled in same logic as the other releases. *...
After a long delay... Inspecting the list of your issues in this thread: * The tracklist in 'master' is often different from them in 'release', so simply preferring 'master' over 'release' is not the solution. But where you are right: 'master' is one more valid source for album informations. So 'release' is is now also selected in addition to 'release' and will have a good chance to become the matching album source, because is selected as first... and handled in same logic as the other releases....
Hi! It seems that ACT v1.4.3 is no longer working. I get an error, and the program closes. Does anyone know how to address this? The .log file is attached. Thanks! Best regards, Ole Thomas
Found a sample for "Index track": https://www.discogs.com/de/master/52081-Dream-Theater-Awake An index track has "sub_tracks". So, the sub tracks shall be added to the tracklist instead of the parent track. Maybe, the titles could be combined. But in my sample, the subtrack were listed as simple tracks on the CD cover. Here is the sample JSON snippet: { "position": "", "type_": "index", "title": "A Mind Beside Itself", "duration": "", "sub_tracks": [ { "position": "4", "type_": "track", "title":...
About the tracklist: I found an album (band "Rage", album "XIII") where ALL search result matches contained non-numeric track numbers. This causes a ClassCastException in "Discogs.loadRelease" at line " (Number) trackEntry.get("position")". The result is that "AlbumInfo.listTracks" is empty. This happened for all search results of this album. This triggers the fallback code "FilterUtil.filterTrackCount": if no search result has a matching track count, all search results are returned. So the search...
I noticed that tracks in a track list have different types. Here is a sample where a type "heading" is used, which is just a separator beetween regular tracks and bonus tracks: https://www.discogs.com/master/40318-The-Crusher/ This breaks the track list count check, if it is added to the track list. I modified my code suggestion for parsing the track list to ignore this type. According to the web UI, there seem to be three types: "Track", "Heading" and "Index Track".
About the tracklist: I found an album (band "Rage", album "XIII") where ALL search result matches contained non-numeric track numbers. This causes a ClassCastException in "Discogs.loadRelease" at line " (Number) trackEntry.get("position")". The result is that "AlbumInfo.listTracks" is empty. This happened for all search results of this album. This triggers the fallback code "FilterUtil.filterTrackCount": if no search result has a matching track count, all search results are returned. So the search...
Hi, how do I import the sources for 1.4.3 in Eclipse? I cannot manage to import them. There are no ".classpath" and ".project" files in the jars, and the Manifest.mf is completelely different compared to the 1.4.2 source package. The 1.4.2 sources were just a zipped Eclipse project I think. Best regards Wolfgang
Now to the next problem: I have this edition: https://www.discogs.com/release/510474-Rage-XIII But the code returned this one (CD+Video boxset): https://www.discogs.com/release/9118303-Rage-XIII The last track name does not match, on the latter, but it is a track that is contained before in the track list. The problem is probably that "DiscogsFilterUtil.filterTrackNames" only checks that all track names of the search result are contained in the MP3 folder. But it does not check the reverse: I have...
Now to the next problem: I have this edition: https://www.discogs.com/release/510474-Rage-XIII But the code returned this one (CD+Video boxset): https://www.discogs.com/release/9118303-Rage-XIII The last track name does not match, on the latter, but it is a track that is contained before in the track list. The problem is probably that "DiscogsFilterUtil.filterTrackNames" only checks that all track names of the search result are contained in the MP3 folder. But it does not check the reverse: I have...
About the tracklist: I found an album (band "Rage", album "XIII") where ALL search result matches contained non-numeric track numbers. This causes a ClassCastException in "Discogs.loadRelease" at line " (Number) trackEntry.get("position")". The result is that "AlbumInfo.listTracks" is empty. This happened for all search results of this album. This triggers the fallback code "FilterUtil.filterTrackCount": if no search result has a matching track count, all search results are returned. So the search...
solved with v1.4.3
solved with v1.4.3
After feedback from Wolfgang a few minor things have changed. Now Discogs should work again, but with a reduces rate limit for their api the software will work much slower...
JAudiotagger 3.0.1 was already in my code. content length check was removed discogs oauth flow was repeaired again -> v1.4.3
About he broken tracklist: this is implemented, but the tracklist is not filled because of a ClassCastException: the "position" property is a string in my sample (at least in the master release): "position": "A1", "type_": "track", and "position": "B1", "type_": "track", Probably A and B site of an LP. Will have to do more research on how to handle this.
Just had a situation where the automatically selected cover was a rather ugly one (scanned LP cover with pale colors and some stickers - it was picked by your code because it had the most images). It was the album "Covered in Blood" from "Arch Enemy". This cover was selected: https://www.discogs.com/release/13101428-Arch-Enemy-Covered-In-Blood. Here is a CD version with a better cover: https://www.discogs.com/release/14105787-Arch-Enemy-Covered-In-Blood And then I noticed that there is a "master"...
About the "Could not invoke DirectBuffer method - illegal access" message: updating "JAudiotagger" to 3.0.1 fixes this.
My car radio does not display the cover pictures. After comparing it with a working file, I found out that the last lineof the following snippet is missing in class "API", method "tagFiles", line 365: imageData.setBinaryData(data); imageData.setMimeType(mimeType); imageData.setPictureType(3); Picture type 3 is "Front Cover". See https://id3.org/id3v2.3.0#Attached_picture Would be nice if you could add it to the tool and do a release. Best regards Wolfgang
My car radio does not display the cover pictures. After comparing it with a working file, I found out that the last lineof the following snippet is missing in class "API", method "tagFiles", line 365: imageData.setBinaryData(data); imageData.setMimeType(mimeType); imageData.setPictureType(3); Picture type 3 is "Front Cover". See [https://id3.org/id3v2.3.0#Attached_picture] Would be nice if you could add it to the tool and do a release. Best regards Wolfgang
My car radio does not display the cover pictures. After comparing it with a working file, I found out that the last lineof the following snippet is missing in class "API", method "tagFiles", line 365: imageData.setBinaryData(data); imageData.setMimeType(mimeType); imageData.setPictureType(3); Picture type 3 is "Front Cover". See (https://id3.org/id3v2.3.0#Attached_picture) Would be nice if you could add it to the tool and do a release. Best regards Wolfgang
My car radio does not display the cover pictures. After comparing it with a working file, I found out that this line is missing in class "API", method "tagFiles", line 365: imageData.setBinaryData(data); imageData.setMimeType(mimeType); **imageData.setPictureType(3);** Picture type 3 is "Front Cover". See (https://id3.org/id3v2.3.0#Attached_picture) Would be nice if you could add it to the tool and do a release. Best regards Wolfgang
It seems the Discogs access does not work any more. I tried to debug it, and it seems the access token is requested successful, but when when "identity" of the current user is fetched, the response is "200 - OK", but the response string is empty - this seems to cause ACT to fail. Hopefully, this project is maintained - I could not find any other tool that downloads CD covers for my MP3s. Best regards Wolfgang
I received this error: org.zoz.cd.source.discogs.ProcessException: 429: {"message":"You are making requests too quickly."} at org.zoz.cd.source.discogs.ClientLoader.doGet(ClientLoader.java:126) at org.zoz.cd.source.discogs.Discogs.determineReleaseUris(Discogs.java:197) at org.zoz.cd.source.discogs.Discogs.loadImage(Discogs.java:125) at org.zoz.cd.API.processDirectory(API.java:222) at org.zoz.cd.API.work(API.java:166) at org.zoz.cd.standalone.UIThreadProgressMonitorAdapter.run(UIThreadProgressMonitorAdapter.java:118)...
I received this error: org.zoz.cd.source.discogs.ProcessException: 429: {"message":"You are making requests too quickly."} at org.zoz.cd.source.discogs.ClientLoader.doGet(ClientLoader.java:126) at org.zoz.cd.source.discogs.Discogs.determineReleaseUris(Discogs.java:197) at org.zoz.cd.source.discogs.Discogs.loadImage(Discogs.java:125) at org.zoz.cd.API.processDirectory(API.java:222) at org.zoz.cd.API.work(API.java:166) at org.zoz.cd.standalone.UIThreadProgressMonitorAdapter.run(UIThreadProgressMonitorAdapter.java:118)...
I received this error: org.zoz.cd.source.discogs.ProcessException: 429: {"message":"You are making requests too quickly."} at org.zoz.cd.source.discogs.ClientLoader.doGet(ClientLoader.java:126) at org.zoz.cd.source.discogs.Discogs.determineReleaseUris(Discogs.java:197) at org.zoz.cd.source.discogs.Discogs.loadImage(Discogs.java:125) at org.zoz.cd.API.processDirectory(API.java:222) at org.zoz.cd.API.work(API.java:166) at org.zoz.cd.standalone.UIThreadProgressMonitorAdapter.run(UIThreadProgressMonitorAdapter.java:118)...
Hi Ralf, glad to hear from you. I pulled your source code and think I found the problem: Class "org.zoz.cd.source.discogs.ClientLoader", line 104: final int cLength = (int) get.getResponseContentLength(); ... if (cLength > 0) The doc for "getResponseContentLength" says "Return -1 when the content-length is unknown. ". Seems that Discogs no longer sets the "Content-Length" header. This works for me: final int cLength = (int) get.getResponseContentLength(); final StringBuffer buffer = new StringBuffer(cLength...
Hi Wolfgang, i will take a look in the next days... Kind regards Ralf
It seems the Discogs access does not work any more. I tried to debug it, and it seems the access token is requested successful, but when when "identity" of the current user is fetched, the response is "200 - OK", but the response string is empty - this seems to cause ACT to fail. Hopefully, this project is maintained - I could not find any other tool that downloads CD covers for my MP3s. Best regards Wolfgang
EDIT: Ok, found the problem... dunno why, but: (java install was borked) A fresh java install did the job. The installation created a hard-(or soft-)link to the above path with files, that are not null bytes in size... Sorry for stealing your time!
EDIT: Ok, found the problem... dunno why, but: (java install was borked) A fresh java install did the job. Sorry for stealing your time!
EDIT: Ok, found the problem... dunno why, but: A fresh java install did the job. Sorry for stealing your time!
I moved it, seems to be the same problem. I started it also fresh from C:\ same problem. Do you can see that I'm using a Win7 64Bit, german language.
I moved it, seems to be the same problem. I started it also fresh from C:\ same problem.
I moved it, seems to be the same problem.
I moved it, seems to be the same problem.
You are using a path like '!stuff'?! Maybe such a strange name brings trouble...
what now? :-)
The working strategy to find album covers is based on (even) albums. An album is...
The working strategy to find album covers is based on (even) albums. An album is...
I need this tool to provide albums covers to about 360 songs(so far) but the log...
Ok, i just uploaded the version 1.4.2 containing a fix for Discogs. Hope all user...
I experience the same problem as Dembala. Are you still planning to adjust to the...
Something in the API of Discogs changed (again). So the validation of the authorization...
Sw doesn't work for me. Click on Discogs link, login to it OK, authorize OK, then...
:o So generous. Thank you for sharing with us.
Discogs has changed the API some weeks ago. HTTP request are not longer supported...
Hello, latest version does not allow me to connect to Discogs. I tried different...
Discogs was reactivated, implementing the OAuth procedure to login a user. You need...
The sources are organized as Eclipse-projects (.project file). You cannot compile/build...
build.properties, but no build.xml file - how do I compile?
Discogs, the only supported source for cover art up to 1.3.0, has introduced a new...