From: Grover, A. <and...@in...> - 2002-04-29 20:10:44
|
> From: Pavel Machek [mailto:pa...@uc...] > I mailed this few days ago. It looks small and simple to me. I'd like > feedback if it was applied or why it was not... Hi Pavel, I've integrated this but I modified it, so I'm attaching the modified files to get your opinion on if I've broken it. ;-) - tersified comments some - removed the "/* NOT REACHED! */" comment, because afaics that comment is wrong - pls explain why you added it. - put the new function in asm/acpi.h, instead of suspend.h. I realize you want a non-ACPI-specific suspend but I think this patch would result in half ACPI-specific and half non-ACPI specific CPU context save, which is not good IMHO. (I also feel better patching files that are clearly ACPI-related.) Is there a way to pull the saving of processor state out into a completely non-ACPI related? Is that feasible? You're undoubtedly more up on the issues involved so please educate me. Thanks -- Regards -- Andy |