RE: [ACPI] RE: [PATCH 1/2] make acpi_path_name() global

[Moore, R. <rob...@in...>]

AcpiGetName is in fact an external interface to ACPICA, and is declared
in acpixf.h.

The three headers that are intended to be "public" are as follows:

Acpiosxf.h - Interfaces to be implemented by the OS interface layer
(OSL).
Acpixf.h - Interfaces to ACPICA, to be used by drivers, etc.
Actypes.h - Types and structs required to use the public interfaces.

The naming convention for ACPICA is that all "non-public" interfaces
contain the prefix "Acpi??" where ?? is the short abbreviation for the
component (Ut =3D Utilities, Dm =3D Disassembler, etc.) Anything without =
the
?? abbreviation is a public interface. Rather than use another
abbreviation, we decided to just drop it for the public interfaces to
keep things short and descriptive.

To clarify things for the world, I would have no problem with renaming
the existing "acpi.h" to something else that indicates it is internal
only, and then renaming actypes.h to acpi.h (or acpica.h) and pulling in
both acpiosxf.h and acpixf.h within it.

This way, we could export acpi.h (or acpica.h) to the world as the
external header for ACPICA.

Bob


> -----Original Message-----
> From: Rajesh Shah [mailto:raj...@in...]
> Sent: Friday, December 16, 2005 10:39 AM
> To: Brown, Len
> Cc: Randy Dunlap; acp...@li...; pcihpd-
> di...@li...; Accardi, Kristen C; gr...@su...;
Moore,
> Robert
> Subject: Re: [ACPI] RE: [PATCH 1/2] make acpi_path_name() global
>=20
> On Thu, Dec 15, 2005 at 11:56:47PM -0500, Brown, Len wrote:
> >
> > an example of this is acpi_get_name(), which as declared
> > isn't supposed to be available outside the core.
> > All the uses of it to print ACPI namespace tokens in /proc
> > are totally bogus and should be deleted.  The other use
> > of it is to print out debug strings -- stuff the OS
> > doesn't really need to "know" and maybe something the
> > core should do for it.  That leaves the hotplug use,
> > which I don't understand.  What does SATA need
>=20
> Hotplug drivers use it to print where we found good, bad or missing
> ACPI methods like _HPP, OSHP, _OSC that we need to work properly.
> This is very useful as a debug aid, since ACPI namespace problems
> have always been the number one reason why the hotplug drivers
> fail to work.
>=20
> thanks,
> Rajesh