|
From: Jeff G. <jg...@po...> - 2005-12-09 11:58:55
|
Matthew Garrett wrote: > On Fri, Dec 09, 2005 at 06:49:44AM -0500, Jeff Garzik wrote: > > >>If this is just for libata, it's still at the wrong level. >> >>libata will eventually make the SCSI simulator optional, which means >>any acpi_scsi_init() or whatnot won't work for libata. > > > It depends on notification whenever a device is added to the scsi bus > class, so it needs access to scsi_bus_type. While that could be put in > the libata layer, it seems cleaner to leave it in scsi and then add > another callback for libata when it moves to its own bus class. If this is for hotswap, as I noted, libata doesn't need this at all. If the hardware supports it, then libata will support it directly. There is no ACPI-specific magic, because ACPI does nothing but talk to the same hardware libata is talking to. Jeff |