aceunit-commit — svn commit digest list (high traffic)

[Aceunit-commit] SF.net SVN: aceunit: [107] trunk/src/native/AceUnit.h

[<chr...@us...>]

Revision: 107
          http://aceunit.svn.sourceforge.net/aceunit/?rev=107&view=rev
Author:   christianhujer
Date:     2007-10-25 15:15:28 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Added guard: AceUnit Embedded currently requires C99.

Modified Paths:
--------------
    trunk/src/native/AceUnit.h

Modified: trunk/src/native/AceUnit.h
===================================================================
--- trunk/src/native/AceUnit.h	2007-10-25 22:15:07 UTC (rev 106)
+++ trunk/src/native/AceUnit.h	2007-10-25 22:15:28 UTC (rev 107)
@@ -30,8 +30,13 @@
  * @file AceUnit.h
  */
 #ifdef ACEUNIT_EMBEDDED
+#if defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 19901L)
 #include <stdint.h>
+#else
+#error "AceUnit does not yet support old C compilers (prior C99) in embedded mode."
+// TODO: change that.
 #endif
+#endif
 
 #include "AceUnitAnnotations.h"
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [106] trunk/src/native/AceUnit.c

[<chr...@us...>]

Revision: 106
          http://aceunit.svn.sourceforge.net/aceunit/?rev=106&view=rev
Author:   christianhujer
Date:     2007-10-25 15:15:07 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Fixed bug in AceUnit.c: lineNumber was int but has to be linenumber_t.

Modified Paths:
--------------
    trunk/src/native/AceUnit.c

Modified: trunk/src/native/AceUnit.c
===================================================================
--- trunk/src/native/AceUnit.c	2007-10-25 22:04:43 UTC (rev 105)
+++ trunk/src/native/AceUnit.c	2007-10-25 22:15:07 UTC (rev 106)
@@ -51,7 +51,7 @@
  * @param lineNumber   Line number of the assertion that failed.
  * @param assertionId  Id of the assertion that failed.
  */
-void recordError(const FixtureId_t fixtureId, const int lineNumber, const AssertionId_t assertionId) {
+void recordError(const FixtureId_t fixtureId, const linenumber_t lineNumber, const AssertionId_t assertionId) {
     recentError = malloc(sizeof(AssertionError_t));
     recentError->fixtureId   = fixtureId;
     recentError->lineNumber  = lineNumber;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [105] trunk/src/native/AceUnit.h

[<chr...@us...>]

Revision: 105
          http://aceunit.svn.sourceforge.net/aceunit/?rev=105&view=rev
Author:   christianhujer
Date:     2007-10-25 15:04:43 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Made sure that AssertionError_t contains 16 bit fields for embedded.

Modified Paths:
--------------
    trunk/src/native/AceUnit.h

Modified: trunk/src/native/AceUnit.h
===================================================================
--- trunk/src/native/AceUnit.h	2007-10-25 22:04:11 UTC (rev 104)
+++ trunk/src/native/AceUnit.h	2007-10-25 22:04:43 UTC (rev 105)
@@ -76,6 +76,13 @@
 #define newAssertionError(message) recordError(__FILE__, __LINE__, message); return
 #endif
 
+/** The type to use for line numbers. */
+#ifdef ACEUNIT_EMBEDDED
+typedef uint16_t linenumber_t;
+#else
+typedef int linenumber_t;
+#endif
+
 /** Assertion Error.
  * @author <a href="mailto:ch...@ri...">Christian Hujer</a>
  */
@@ -88,7 +95,7 @@
     TestCaseId_t testId;
 
     /** The line number of the failed assertion. */
-    int lineNumber;
+    linenumber_t lineNumber;
 
     /** The assertion id. */
     AssertionId_t assertionId;
@@ -170,7 +177,7 @@
  * @param lineNumber   Line number of the assertion that failed.
  * @param assertionId  Id of the assertion that failed.
  */
-extern void recordError(const FixtureId_t fixtureId, const int lineNumber, const AssertionId_t assertionId);
+extern void recordError(const FixtureId_t fixtureId, const linenumber_t lineNumber, const AssertionId_t assertionId);
 
 /** Runs all test cases from a test fixture.
  * @param fixture  Test fixture to run.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [104] trunk/src/native/MiniRamLogger.c

[<chr...@us...>]

Revision: 104
          http://aceunit.svn.sourceforge.net/aceunit/?rev=104&view=rev
Author:   christianhujer
Date:     2007-10-25 15:04:11 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Added guard that MiniRamLogger will only be used in embedded mode.

Modified Paths:
--------------
    trunk/src/native/MiniRamLogger.c

Modified: trunk/src/native/MiniRamLogger.c
===================================================================
--- trunk/src/native/MiniRamLogger.c	2007-10-25 22:02:48 UTC (rev 103)
+++ trunk/src/native/MiniRamLogger.c	2007-10-25 22:04:11 UTC (rev 104)
@@ -36,6 +36,9 @@
 #include <string.h>
 
 #include "AceUnit.h"
+#ifndef ACEUNIT_EMBEDDED
+#error "MiniRamLogger can only be used for ACEUNIT_EMBEDDED."
+#endif
 
 #ifndef ACEUNIT_MINIRAM_LOGGER_BUFSIZE
 /** The size of the buffer that's used for the Mini Ram Logger. */


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [103] trunk/src/native/MiniRamLogger.c

[<chr...@us...>]

Revision: 103
          http://aceunit.svn.sourceforge.net/aceunit/?rev=103&view=rev
Author:   christianhujer
Date:     2007-10-25 15:02:48 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Added BOM (byte order mark) to MiniRamLogger's output file.

Modified Paths:
--------------
    trunk/src/native/MiniRamLogger.c

Modified: trunk/src/native/MiniRamLogger.c
===================================================================
--- trunk/src/native/MiniRamLogger.c	2007-10-25 21:51:04 UTC (rev 102)
+++ trunk/src/native/MiniRamLogger.c	2007-10-25 22:02:48 UTC (rev 103)
@@ -65,5 +65,11 @@
  * @param file File to write to.
  */
 void MiniRamLoggerSave(FILE *file) {
+    // The file will first contain a BOM (byte order mark).
+    // That enables tools that read this file to find out whether it was written in Big Endian or Little Endian.
+    uint16_t bom = 0xFFFE;
+    fwrite(&bom, sizeof(uint16_t), 1, file);
+
+    // Now write the data.
     fwrite(data, sizeof(AssertionError_t), elementCount, file);
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [102] trunk/src/native/MiniRamLogger.c

[<chr...@us...>]

Revision: 102
          http://aceunit.svn.sourceforge.net/aceunit/?rev=102&view=rev
Author:   christianhujer
Date:     2007-10-25 14:51:04 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Added MiniRamLogger.

Added Paths:
-----------
    trunk/src/native/MiniRamLogger.c

Added: trunk/src/native/MiniRamLogger.c
===================================================================
--- trunk/src/native/MiniRamLogger.c	                        (rev 0)
+++ trunk/src/native/MiniRamLogger.c	2007-10-25 21:51:04 UTC (rev 102)
@@ -0,0 +1,69 @@
+/* Copyright (c) 2007, Christian Hujer
+ * All rights reserved.
+ * 
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of the AceUnit developers nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ * 
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
+ * OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+ * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/** Mini Ram Logger implementation that logs messages to RAM with as little memory consumption as possible.
+ * The format of the messages is suitable for postprocessing to convert it into the same format as that of {@link FullPlainLogger.c}.
+ * This Logger also could serve as a template if you want to create your own logger that e.g. logs by writing to a NVM like EEPROM or Flash.
+ * @author <a href="mailto:ch...@ri...">Christian Hujer</a>
+ * @file MiniRamLogger.c
+ */
+
+#include <stdio.h>
+#include <string.h>
+
+#include "AceUnit.h"
+
+#ifndef ACEUNIT_MINIRAM_LOGGER_BUFSIZE
+/** The size of the buffer that's used for the Mini Ram Logger. */
+#define ACEUNIT_MINIRAM_LOGGER_BUFSIZE 32
+#endif
+
+/** The number of valid logging elements in #data. */
+size_t elementCount;
+
+/** AceUnit Mini Ram Logger data buffer. */
+AssertionError_t data[ACEUNIT_MINIRAM_LOGGER_BUFSIZE];
+
+/** Initializes the Mini Ram Logger. */
+void MiniRamLoggerInit() {
+    elementCount = 0;
+    memset(data, 0, sizeof(data));
+}
+
+/** Logs a message using this logger.
+ * @param recentError Error to log.
+ */
+void MiniRamLoggerLog(const AssertionError_t *const recentError) {
+    data[elementCount++] = *recentError;
+}
+
+/** Writes contents of the Mini Ram Logger to a file.
+ * @param file File to write to.
+ */
+void MiniRamLoggerSave(FILE *file) {
+    fwrite(data, sizeof(AssertionError_t), elementCount, file);
+}


Property changes on: trunk/src/native/MiniRamLogger.c
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [101] trunk/src/native/Doxyfile

[<chr...@us...>]

Revision: 101
          http://aceunit.svn.sourceforge.net/aceunit/?rev=101&view=rev
Author:   christianhujer
Date:     2007-10-25 14:10:38 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Fixed bug in Doxygen configuration: undocumented members did not produce a warning.

Modified Paths:
--------------
    trunk/src/native/Doxyfile

Modified: trunk/src/native/Doxyfile
===================================================================
--- trunk/src/native/Doxyfile	2007-10-25 21:04:34 UTC (rev 100)
+++ trunk/src/native/Doxyfile	2007-10-25 21:10:38 UTC (rev 101)
@@ -228,7 +228,7 @@
 # Private class members and static file members will be hidden unless 
 # the EXTRACT_PRIVATE and EXTRACT_STATIC tags are set to YES
 
-EXTRACT_ALL            = YES
+EXTRACT_ALL            = NO
 
 # If the EXTRACT_PRIVATE tag is set to YES all private members of a class 
 # will be included in the documentation.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [100] trunk/src/native/test/AceUnitTest.c

[<chr...@us...>]

Revision: 100
          http://aceunit.svn.sourceforge.net/aceunit/?rev=100&view=rev
Author:   christianhujer
Date:     2007-10-25 14:04:34 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Added Test Cases for assertFalse().

Modified Paths:
--------------
    trunk/src/native/test/AceUnitTest.c

Modified: trunk/src/native/test/AceUnitTest.c
===================================================================
--- trunk/src/native/test/AceUnitTest.c	2007-10-25 21:04:15 UTC (rev 99)
+++ trunk/src/native/test/AceUnitTest.c	2007-10-25 21:04:34 UTC (rev 100)
@@ -48,7 +48,16 @@
 
 /** Tests that {@link #assertTrue()} with a true condition continues a test case. */
 A_Test void testAssertTrueWithTrueContinues() {
-    assertTrue("assertTrue(msg, true) MUST continue the test case.", true);
+    bool assertionContinued = false;
+    void helper() {
+        assertTrue("assertTrue(msg, true) MUST continue the test case.", true);
+        assertionContinued = true;
+    }
+    helper();
+    clearRecentError();
+    if (!assertionContinued) {
+        fail("Expected assertion to continue.");
+    }
 }
 
 /** Tests that {@link #assertTrue()} with a false condition does not continue a test case. */
@@ -91,6 +100,60 @@
     }
 }
 
+/** Tests that {@link #assertFalse()} with a true condition continues a test case. */
+A_Test void testAssertFalseWithFalseContinues() {
+    bool assertionContinued = false;
+    void helper() {
+        assertFalse("assertFalse(msg, false) MUST continue the test case.", false);
+        assertionContinued = true;
+    }
+    helper();
+    clearRecentError();
+    if (!assertionContinued) {
+        fail("Expected assertion to continue.");
+    }
+}
+
+/** Tests that {@link #assertFalse()} with a false condition does not continue a test case. */
+A_Test void testAssertFalseWithTrueReturns() {
+    bool assertionContinued = false;
+    void helper() {
+        assertFalse("Test assertion, expected to fail.", true);
+        assertionContinued = true;
+    }
+    helper();
+    clearRecentError();
+    if (assertionContinued) {
+        fail("Expected assertion to not continue.");
+    }
+}
+
+/** Tests that {@link #assertFalse()} with a true condition does not set recentError. */
+A_Test void testAssertFalseWithFalseNoRecentError() {
+    clearRecentError();
+    assertFalse("assertFalse(msg, false) MUST NOT set recentError.", false);
+    if (recentError != NULL) {
+        fail("Expected recentError to be NULL.");
+    }
+}
+
+/** Tests that {@link #assertFalse()} with a false condition sets recentError. */
+A_Test void testAssertFalseWithTrueSetsRecentError() {
+    bool recentErrorSet = false;
+    clearRecentError();
+    void helper() {
+        assertFalse("Test assertion, expected to fail.", true);
+    }
+    helper();
+    if (recentError != NULL) {
+        recentErrorSet = true;
+    }
+    clearRecentError();
+    if (!recentErrorSet) {
+        fail("Expected recentError to be set.");
+    }
+}
+
 #include "AceUnitTest.h"
 
 // Run the tests.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [99] trunk/src/native/test/Makefile

[<chr...@us...>]

Revision: 99
          http://aceunit.svn.sourceforge.net/aceunit/?rev=99&view=rev
Author:   christianhujer
Date:     2007-10-25 14:04:15 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Changed Makefile to auto-run tests.

Modified Paths:
--------------
    trunk/src/native/test/Makefile

Modified: trunk/src/native/test/Makefile
===================================================================
--- trunk/src/native/test/Makefile	2007-10-25 20:35:31 UTC (rev 98)
+++ trunk/src/native/test/Makefile	2007-10-25 21:04:15 UTC (rev 99)
@@ -4,7 +4,7 @@
 
 FIXTURE_NAME=AceUnitTest
 
-all: prepare compile
+all: prepare compile test
 
 clean:
 	rm -f $(ACE_UNIT_FILES) $(FIXTURE_NAME).h runTests
@@ -36,3 +36,6 @@
 
 runTests: $(FIXTURE_NAME).c $(FIXTURE_NAME).h $(ACE_UNIT_FILES)
 	$(CC) -Wall -g -o runTests *.c
+
+test: runTests
+	./runTests


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [98] trunk/src/doc/aceunit_logo.svg

[<chr...@us...>]

Revision: 98
          http://aceunit.svn.sourceforge.net/aceunit/?rev=98&view=rev
Author:   christianhujer
Date:     2007-10-25 13:35:31 -0700 (Thu, 25 Oct 2007)

Log Message:
-----------
Added Logo.

Added Paths:
-----------
    trunk/src/doc/aceunit_logo.svg

Added: trunk/src/doc/aceunit_logo.svg
===================================================================
--- trunk/src/doc/aceunit_logo.svg	                        (rev 0)
+++ trunk/src/doc/aceunit_logo.svg	2007-10-25 20:35:31 UTC (rev 98)
@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG1.1/DTD/svg11.dtd"
+[
+    <!ENTITY black "#404000">
+    <!ENTITY yellow "#D9D900">
+]
+>
+<svg width="250" height="90" version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 90">
+    <defs>
+        <filter id="MyFilter" filterUnits="userSpaceOnUse" x="0" y="0" width="250" height="90">
+            <feGaussianBlur in="SourceAlpha" stdDeviation="4" result="blur"/>
+            <feOffset in="blur" dx="4" dy="4" result="offsetBlur"/>
+            <feSpecularLighting in="blur" surfaceScale="5" specularConstant=".75" specularExponent="20" lighting-color="#bbbbbb"  result="specOut">
+                <fePointLight x="-5000" y="-10000" z="20000"/>
+            </feSpecularLighting>
+            <feComposite in="specOut" in2="SourceAlpha" operator="in" result="specOut"/>
+            <feComposite in="SourceGraphic" in2="specOut" operator="arithmetic" k1="0" k2="1" k3="1" k4="0" result="litPaint"/>
+            <feMerge>
+                <feMergeNode in="offsetBlur"/>
+                <feMergeNode in="litPaint"/>
+            </feMerge>
+        </filter>
+        <g id="pill" transform="scale(0.4)">
+            <!--path stroke="#D9D900" fill="#D90000" d="M0,20 L0,-20 L40,-20 C70,-20 70,20 40,20 z" /-->
+            <!--path stroke="#D9D900" fill="#0000D9" d="M-40,20 C-70,20 -70,-20 -40,-20 L0,-20 L0,20 z" /-->
+            <path stroke="&black;" fill="&yellow;" d="M0,20 L0,-20 L40,-20 C70,-20 70,20 40,20 z" />
+            <path stroke="&black;" fill="&black;" d="M-40,20 C-70,20 -70,-20 -40,-20 L0,-20 L0,20 z" />
+        </g>
+    </defs>
+    <g filter="url(#MyFilter)">
+        <use xlink:href="#pill" transform="translate(30 40) rotate(-45)"/>
+        <text fill="&yellow;" stroke="&black;" x="50" y="60" font-size="45" font-weight="bold" font-family="Lucida Bright">AceUnit</text>
+    </g>
+</svg>


Property changes on: trunk/src/doc/aceunit_logo.svg
___________________________________________________________________
Name: svn:mime-type
   + text/xml
Name: svn:eol-style
   + LF


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [97] trunk/src/doc/start.xhtml

[<chr...@us...>]

Revision: 97
          http://aceunit.svn.sourceforge.net/aceunit/?rev=97&view=rev
Author:   christianhujer
Date:     2007-10-23 12:22:02 -0700 (Tue, 23 Oct 2007)

Log Message:
-----------
Added slogan.

Modified Paths:
--------------
    trunk/src/doc/start.xhtml

Modified: trunk/src/doc/start.xhtml
===================================================================
--- trunk/src/doc/start.xhtml	2007-10-19 18:22:27 UTC (rev 96)
+++ trunk/src/doc/start.xhtml	2007-10-23 19:22:02 UTC (rev 97)
@@ -29,6 +29,9 @@
             AceUnit is JUnit 4.x style, easy, modular and flexible.
             AceUnit can be used in resource constraint environments, e.g. embedded software development.
         </p>
+        <p>
+            AceUnit's current slogan is: <strong>Vitamins for your software quality!</strong>
+        </p>
         <h2>Download AceUnit</h2>
         <p>
             To download AceUnit, go to the <a href="http://sourceforge.net/project/showfiles.php?group_id=207094">Download Section</a> of the sourceforge project site.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [96] trunk/src/doc/build.xml

[<chr...@us...>]

Revision: 96
          http://aceunit.svn.sourceforge.net/aceunit/?rev=96&view=rev
Author:   christianhujer
Date:     2007-10-19 11:22:27 -0700 (Fri, 19 Oct 2007)

Log Message:
-----------
Fixed bug in documentation build.xml. docs/ was copied to itself recursively.

Modified Paths:
--------------
    trunk/src/doc/build.xml

Modified: trunk/src/doc/build.xml
===================================================================
--- trunk/src/doc/build.xml	2007-10-17 22:20:13 UTC (rev 95)
+++ trunk/src/doc/build.xml	2007-10-19 18:22:27 UTC (rev 96)
@@ -76,6 +76,7 @@
                 <include name="**/.htaccess" />
                 <include name="**/*.css" />
                 <exclude name="**/.xvpics/*.png" />
+                <exclude name="**/docs/**" />
             </fileset>
         </copy>
     </target>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [95] trunk/src/doc/start.xhtml

[<chr...@us...>]

Revision: 95
          http://aceunit.svn.sourceforge.net/aceunit/?rev=95&view=rev
Author:   christianhujer
Date:     2007-10-17 15:20:13 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Updated release version.

Modified Paths:
--------------
    trunk/src/doc/start.xhtml

Modified: trunk/src/doc/start.xhtml
===================================================================
--- trunk/src/doc/start.xhtml	2007-10-17 22:18:56 UTC (rev 94)
+++ trunk/src/doc/start.xhtml	2007-10-17 22:20:13 UTC (rev 95)
@@ -20,7 +20,7 @@
         </div>
         -->
         <p>
-            Latest release version: <strong>aceunit-0.1.1</strong>
+            Latest release version: <strong>aceunit-0.1.2</strong>
         </p>
         <h2>What is AceUnit?</h2>
         <!-- The description must match the project description at http://sourceforge.net/projects/aceunit/ -->


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [94] release.sh

[<chr...@us...>]

Revision: 94
          http://aceunit.svn.sourceforge.net/aceunit/?rev=94&view=rev
Author:   christianhujer
Date:     2007-10-17 15:18:56 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Added release script.

Added Paths:
-----------
    release.sh

Added: release.sh
===================================================================
--- release.sh	                        (rev 0)
+++ release.sh	2007-10-17 22:18:56 UTC (rev 94)
@@ -0,0 +1,22 @@
+#!/bin/sh
+
+# TODO: Use freshmeat-submit
+# TODO: Support release levels
+
+echo "Usage: ./release.sh <branch-name> <release-name> <email-address>"
+svn cp -m "Creating release tag $2 for branch $1." http://aceunit.svn.sourceforge.net/svnroot/aceunit/branches/$1 http://aceunit.svn.sourceforge.net/svnroot/aceunit/tags/$2
+svn export http://aceunit.svn.sourceforge.net/svnroot/aceunit/tags/$2 aceunit
+tar cjvf aceunit-$2-src.tar.bz2 aceunit
+tar czvf aceunit-$2-src.tar.gz aceunit
+zip -r aceunit-$2-src.zip aceunit
+ftp -u ftp://anonymous:$3...@up.../incoming aceunit-$2-src.*
+echo
+echo "Upload done. Now create a new release at sourceforge and freshmeat, the mailing list and the forum."
+echo "SourceForge:  http://sourceforge.net/project/admin/newrelease.php?package_id=247827&group_id=207094"
+echo "FreshMeat:    http://freshmeat.net/add-release/66354/"
+echo "News Forum:   http://sourceforge.net/news/submit.php?group_id=207094"
+echo "Mailing List: mailto:ace...@li..."
+echo "You should use the same description there."
+echo "The description should include the project description."
+echo "The normative project description is at: http://sourceforge.net/projects/aceunit/"
+echo "Don't forget to update the homepage. cd to aceunit/src/doc, change start.xhtml and run ant uploadDoc."


Property changes on: release.sh
___________________________________________________________________
Name: svn:executable
   + *


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [93] tags/0.1.2/

[<chr...@us...>]

Revision: 93
          http://aceunit.svn.sourceforge.net/aceunit/?rev=93&view=rev
Author:   christianhujer
Date:     2007-10-17 15:03:25 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Creating release tag 0.1.2 for branch 0.1.

Added Paths:
-----------
    tags/0.1.2/

Copied: tags/0.1.2 (from rev 92, branches/0.1)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [92] trunk/src

[<chr...@us...>]

Revision: 92
          http://aceunit.svn.sourceforge.net/aceunit/?rev=92&view=rev
Author:   christianhujer
Date:     2007-10-17 15:01:42 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Simplified, generalized and unified Makefiles.

Modified Paths:
--------------
    trunk/src/doc/examples/sort/Makefile
    trunk/src/native/test/Makefile

Modified: trunk/src/doc/examples/sort/Makefile
===================================================================
--- trunk/src/doc/examples/sort/Makefile	2007-10-17 21:50:27 UTC (rev 91)
+++ trunk/src/doc/examples/sort/Makefile	2007-10-17 22:01:42 UTC (rev 92)
@@ -1,11 +1,15 @@
+ACE_UNIT_FILES=AceUnit.c AceUnit.h AceUnitAnnotations.h FullPlainLogger.c AceUnit.jar
+
 ACE_UNIT_PATH=../../../
 
+FIXTURE_NAME=sortTest
+
 all: prepare compile
 
 clean:
-	rm -f AceUnit.c AceUnit.h AceUnitAnnotations.h FullPlainLogger.c AceUnit.jar sortTest.h runTests
+	rm -f $(ACE_UNIT_FILES) $(FIXTURE_NAME).h runTests
 
-prepare: AceUnit.c AceUnit.h AceUnitAnnotations.h FullPlainLogger.c
+prepare: $(ACE_UNIT_FILES)
 
 AceUnit.c: $(ACE_UNIT_PATH)/native/AceUnit.c
 	cp $< $@
@@ -27,8 +31,8 @@
 
 compile: runTests
 
-sortTest.h: AceUnit.jar sortTest.c
-	java -jar AceUnit.jar sortTest >sortTest.h
+$(FIXTURE_NAME).h: AceUnit.jar $(FIXTURE_NAME).c
+	java -jar AceUnit.jar $(FIXTURE_NAME) >$(FIXTURE_NAME).h
 
-runTests: *.c *.h sortTest.h
-	gcc -Wall -g -o runTests *.c
+runTests: $(FIXTURE_NAME).c $(FIXTURE_NAME).h $(ACE_UNIT_FILES)
+	$(CC) -Wall -g -o runTests *.c

Modified: trunk/src/native/test/Makefile
===================================================================
--- trunk/src/native/test/Makefile	2007-10-17 21:50:27 UTC (rev 91)
+++ trunk/src/native/test/Makefile	2007-10-17 22:01:42 UTC (rev 92)
@@ -2,10 +2,12 @@
 
 ACE_UNIT_PATH=../../
 
+FIXTURE_NAME=AceUnitTest
+
 all: prepare compile
 
 clean:
-	rm -f $(ACE_UNIT_FILES) AceUnitTest.h runTests
+	rm -f $(ACE_UNIT_FILES) $(FIXTURE_NAME).h runTests
 
 prepare: $(ACE_UNIT_FILES)
 
@@ -29,8 +31,8 @@
 
 compile: runTests
 
-AceUnitTest.h: AceUnit.jar AceUnitTest.c
-	java -jar AceUnit.jar AceUnitTest >AceUnitTest.h
+$(FIXTURE_NAME).h: AceUnit.jar $(FIXTURE_NAME).c
+	java -jar AceUnit.jar $(FIXTURE_NAME) >$(FIXTURE_NAME).h
 
-runTests: AceUnitTest.c AceUnitTest.h $(ACE_UNIT_FILES)
+runTests: $(FIXTURE_NAME).c $(FIXTURE_NAME).h $(ACE_UNIT_FILES)
 	$(CC) -Wall -g -o runTests *.c


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [91] trunk/src/native/AceUnit.c

[<chr...@us...>]

Revision: 91
          http://aceunit.svn.sourceforge.net/aceunit/?rev=91&view=rev
Author:   christianhujer
Date:     2007-10-17 14:50:27 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Added method to run more than one fixture.

Modified Paths:
--------------
    trunk/src/native/AceUnit.c

Modified: trunk/src/native/AceUnit.c
===================================================================
--- trunk/src/native/AceUnit.c	2007-10-17 21:49:55 UTC (rev 90)
+++ trunk/src/native/AceUnit.c	2007-10-17 21:50:27 UTC (rev 91)
@@ -94,5 +94,15 @@
 #undef invokeAll
 }
 
+/** Runs all test cases from the supplied fixtures.
+ * @param fixtures  Test fixtures to run (NULL terminated).
+ */
+void runFixtures(const TestFixture_t *const *fixtures) {
+    while (*fixtures != NULL) {
+        runFixture(*fixtures);
+        fixtures++;
+    }
+}
+
 // TODO: Add method to run specified test cases from a test fixture.
 // This should be done by a linear search through the list of test cases.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [90] trunk/src/native/test/Makefile

[<chr...@us...>]

Revision: 90
          http://aceunit.svn.sourceforge.net/aceunit/?rev=90&view=rev
Author:   christianhujer
Date:     2007-10-17 14:49:55 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Made Makefile more general (independent of gcc).

Modified Paths:
--------------
    trunk/src/native/test/Makefile

Modified: trunk/src/native/test/Makefile
===================================================================
--- trunk/src/native/test/Makefile	2007-10-17 21:48:12 UTC (rev 89)
+++ trunk/src/native/test/Makefile	2007-10-17 21:49:55 UTC (rev 90)
@@ -33,4 +33,4 @@
 	java -jar AceUnit.jar AceUnitTest >AceUnitTest.h
 
 runTests: AceUnitTest.c AceUnitTest.h $(ACE_UNIT_FILES)
-	gcc -Wall -g -o runTests *.c
+	$(CC) -Wall -g -o runTests *.c


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [89] trunk/src/native/AceUnit.h

[<chr...@us...>]

Revision: 89
          http://aceunit.svn.sourceforge.net/aceunit/?rev=89&view=rev
Author:   christianhujer
Date:     2007-10-17 14:48:12 -0700 (Wed, 17 Oct 2007)

Log Message:
-----------
Changed order of AssertionError_t fields.

Modified Paths:
--------------
    trunk/src/native/AceUnit.h

Modified: trunk/src/native/AceUnit.h
===================================================================
--- trunk/src/native/AceUnit.h	2007-10-16 21:54:32 UTC (rev 88)
+++ trunk/src/native/AceUnit.h	2007-10-17 21:48:12 UTC (rev 89)
@@ -84,12 +84,12 @@
     /** The id of the fixture that contains the test case of the failed assertion. */
     FixtureId_t fixtureId;
 
+    /** The id of the test case of the failed assertion. */
+    TestCaseId_t testId;
+
     /** The line number of the failed assertion. */
     int lineNumber;
 
-    /** The id of the test case of the failed assertion. */
-    TestCaseId_t testId;
-
     /** The assertion id. */
     AssertionId_t assertionId;
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [88] trunk/src/native/test/AceUnitTest.c

[<chr...@us...>]

Revision: 88
          http://aceunit.svn.sourceforge.net/aceunit/?rev=88&view=rev
Author:   christianhujer
Date:     2007-10-16 14:54:32 -0700 (Tue, 16 Oct 2007)

Log Message:
-----------
Completed unit tests for assertTrue().

Modified Paths:
--------------
    trunk/src/native/test/AceUnitTest.c

Modified: trunk/src/native/test/AceUnitTest.c
===================================================================
--- trunk/src/native/test/AceUnitTest.c	2007-10-16 21:17:48 UTC (rev 87)
+++ trunk/src/native/test/AceUnitTest.c	2007-10-16 21:54:32 UTC (rev 88)
@@ -36,29 +36,61 @@
 
 #include "AceUnit.h"
 
-/** Verifies that {@link #assertTrue()} with a true condition continues a test case. */
+extern AssertionError_t* recentError;
+
+/** Clears and frees the current recent error. */
+void clearRecentError() {
+    if (recentError != NULL) {
+        free(recentError);
+        recentError = NULL;
+    }
+}
+
+/** Tests that {@link #assertTrue()} with a true condition continues a test case. */
 A_Test void testAssertTrueWithTrueContinues() {
     assertTrue("assertTrue(msg, true) MUST continue the test case.", true);
 }
 
-/** Verifies that {@link #assertTrue()} with a false condition does not continue a test case. */
+/** Tests that {@link #assertTrue()} with a false condition does not continue a test case. */
 A_Test void testAssertTrueWithFalseReturns() {
-    extern AssertionError_t* recentError;
     bool assertionContinued = false;
     void helper() {
         assertTrue("Test assertion, expected to fail.", false);
         assertionContinued = true;
     }
     helper();
-    if (recentError != NULL) {
-        free(recentError);
-        recentError = NULL;
-    }
+    clearRecentError();
     if (assertionContinued) {
         fail("Expected assertion to not continue.");
     }
 }
 
+/** Tests that {@link #assertTrue()} with a true condition does not set recentError. */
+A_Test void testAssertTrueWithTrueNoRecentError() {
+    clearRecentError();
+    assertTrue("assertTrue(msg, true) MUST NOT set recentError.", true);
+    if (recentError != NULL) {
+        fail("Expected recentError to be NULL.");
+    }
+}
+
+/** Tests that {@link #assertTrue()} with a false condition sets recentError. */
+A_Test void testAssertTrueWithFalseSetsRecentError() {
+    bool recentErrorSet = false;
+    clearRecentError();
+    void helper() {
+        assertTrue("Test assertion, expected to fail.", false);
+    }
+    helper();
+    if (recentError != NULL) {
+        recentErrorSet = true;
+    }
+    clearRecentError();
+    if (!recentErrorSet) {
+        fail("Expected recentError to be set.");
+    }
+}
+
 #include "AceUnitTest.h"
 
 // Run the tests.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [87] trunk/src/native/FullPlainLogger.c

[<chr...@us...>]

Revision: 87
          http://aceunit.svn.sourceforge.net/aceunit/?rev=87&view=rev
Author:   christianhujer
Date:     2007-10-16 14:17:48 -0700 (Tue, 16 Oct 2007)

Log Message:
-----------
FullPlainLogger does not support embedded AceUnit.

Modified Paths:
--------------
    trunk/src/native/FullPlainLogger.c

Modified: trunk/src/native/FullPlainLogger.c
===================================================================
--- trunk/src/native/FullPlainLogger.c	2007-10-16 21:15:53 UTC (rev 86)
+++ trunk/src/native/FullPlainLogger.c	2007-10-16 21:17:48 UTC (rev 87)
@@ -41,7 +41,7 @@
  */
 void FullPlainLoggerLog(const AssertionError_t *const recentError) {
 #ifdef ACEUNIT_EMBEDDED
-    // TODO
+#error "FullPlainLogger does not support embedded AceUnit."
 #else
     printf("%s:%d: error: in %s: %s\n", recentError->fixtureId, recentError->lineNumber, recentError->testId, recentError->assertionId);
 #endif


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [86] trunk/src/native

[<chr...@us...>]

Revision: 86
          http://aceunit.svn.sourceforge.net/aceunit/?rev=86&view=rev
Author:   christianhujer
Date:     2007-10-16 14:15:53 -0700 (Tue, 16 Oct 2007)

Log Message:
-----------
Added unit test to test AceUnit with itself. (Not completed yet)

Added Paths:
-----------
    trunk/src/native/test/
    trunk/src/native/test/AceUnitTest.c
    trunk/src/native/test/Makefile

Added: trunk/src/native/test/AceUnitTest.c
===================================================================
--- trunk/src/native/test/AceUnitTest.c	                        (rev 0)
+++ trunk/src/native/test/AceUnitTest.c	2007-10-16 21:15:53 UTC (rev 86)
@@ -0,0 +1,70 @@
+/* Copyright (c) 2007, Christian Hujer
+ * All rights reserved.
+ * 
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of the AceUnit developers nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ * 
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
+ * OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+ * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/** Unit Test for AceUnit.
+ * Yes, AceUnit can be tested using itself.
+ * @author <a href="mailto:ch...@ri...">Christian Hujer</a>
+ * @file AceUnitTest.c
+ */
+
+#include <stdbool.h>
+#include <stdlib.h>
+
+#include "AceUnit.h"
+
+/** Verifies that {@link #assertTrue()} with a true condition continues a test case. */
+A_Test void testAssertTrueWithTrueContinues() {
+    assertTrue("assertTrue(msg, true) MUST continue the test case.", true);
+}
+
+/** Verifies that {@link #assertTrue()} with a false condition does not continue a test case. */
+A_Test void testAssertTrueWithFalseReturns() {
+    extern AssertionError_t* recentError;
+    bool assertionContinued = false;
+    void helper() {
+        assertTrue("Test assertion, expected to fail.", false);
+        assertionContinued = true;
+    }
+    helper();
+    if (recentError != NULL) {
+        free(recentError);
+        recentError = NULL;
+    }
+    if (assertionContinued) {
+        fail("Expected assertion to not continue.");
+    }
+}
+
+#include "AceUnitTest.h"
+
+// Run the tests.
+// Note: This is only here temporarily.
+// In future versions, this part will be auto-generated.
+int main(int argc, char *argv[]) {
+    runFixture(&AceUnitTestFixture);
+    return 0;
+}


Property changes on: trunk/src/native/test/AceUnitTest.c
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native

Added: trunk/src/native/test/Makefile
===================================================================
--- trunk/src/native/test/Makefile	                        (rev 0)
+++ trunk/src/native/test/Makefile	2007-10-16 21:15:53 UTC (rev 86)
@@ -0,0 +1,36 @@
+ACE_UNIT_FILES=AceUnit.c AceUnit.h AceUnitAnnotations.h FullPlainLogger.c AceUnit.jar
+
+ACE_UNIT_PATH=../../
+
+all: prepare compile
+
+clean:
+	rm -f $(ACE_UNIT_FILES) AceUnitTest.h runTests
+
+prepare: $(ACE_UNIT_FILES)
+
+AceUnit.c: $(ACE_UNIT_PATH)/native/AceUnit.c
+	cp $< $@
+
+AceUnit.h: $(ACE_UNIT_PATH)/native/AceUnit.h
+	cp $< $@
+
+AceUnitAnnotations.h: $(ACE_UNIT_PATH)/native/AceUnitAnnotations.h
+	cp $< $@
+
+FullPlainLogger.c: $(ACE_UNIT_PATH)/native/FullPlainLogger.c
+	cp $< $@
+
+AceUnit.jar: $(ACE_UNIT_PATH)/java/AceUnit.jar
+	cp $< $@
+
+$(ACE_UNIT_PATH)/java/AceUnit.jar:
+	(cd $(ACE_UNIT_PATH)/java ; ant)
+
+compile: runTests
+
+AceUnitTest.h: AceUnit.jar AceUnitTest.c
+	java -jar AceUnit.jar AceUnitTest >AceUnitTest.h
+
+runTests: AceUnitTest.c AceUnitTest.h $(ACE_UNIT_FILES)
+	gcc -Wall -g -o runTests *.c


Property changes on: trunk/src/native/test/Makefile
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [85] trunk/src/doc/manual.xhtml

[<chr...@us...>]

Revision: 85
          http://aceunit.svn.sourceforge.net/aceunit/?rev=85&view=rev
Author:   christianhujer
Date:     2007-10-14 11:24:08 -0700 (Sun, 14 Oct 2007)

Log Message:
-----------
Added note about embedded not working 100% right now.

Modified Paths:
--------------
    trunk/src/doc/manual.xhtml

Modified: trunk/src/doc/manual.xhtml
===================================================================
--- trunk/src/doc/manual.xhtml	2007-10-14 17:19:03 UTC (rev 84)
+++ trunk/src/doc/manual.xhtml	2007-10-14 18:24:08 UTC (rev 85)
@@ -163,6 +163,7 @@
                 By defining this macro you will turn AceUnit into embedded mode.
                 In embedded mode, AceUnit tries to consume as little memory as possible.
                 For instance, all strings are replaced by 16 bit values.
+                Note: Currently this macro is not 100% functional.
             </dd>
         </dl>
     </body>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [84] branches/0.1/src/native/AceUnit.h

[<chr...@us...>]

Revision: 84
          http://aceunit.svn.sourceforge.net/aceunit/?rev=84&view=rev
Author:   christianhujer
Date:     2007-10-14 10:19:03 -0700 (Sun, 14 Oct 2007)

Log Message:
-----------
Copied bugfix from trunk to branch.

Modified Paths:
--------------
    branches/0.1/src/native/AceUnit.h

Modified: branches/0.1/src/native/AceUnit.h
===================================================================
--- branches/0.1/src/native/AceUnit.h	2007-10-14 17:18:13 UTC (rev 83)
+++ branches/0.1/src/native/AceUnit.h	2007-10-14 17:19:03 UTC (rev 84)
@@ -139,7 +139,7 @@
  * @param message Message, usually with the positive description of why the assertion should not fail.
  * @param condition Condition to assert.
  */
-#define assertTrue(message, condition) if (!condition) { fail(message); }
+#define assertTrue(message, condition) if (!(condition)) { fail(message); }
 
 /** Asserts that the specified condition is false.
  * If the condition is not false, the test case fails and raises an Assertion Error that will be logged.
@@ -154,7 +154,7 @@
  * @param expected Expected value.
  * @param actual Actual value.
  */
-#define assertEquals(message, expected, actual) if (!(expected == actual)) { fail(message); } // TODO: expected vs. actual in message
+#define assertEquals(message, expected, actual) if (!((expected) == (actual))) { fail(message); } // TODO: expected vs. actual in message
 
 /** Asserts that two values are not equal.
  * If the values are equal, the test case fails and raises an {@link AssertionError_t} that will be logged.
@@ -162,7 +162,7 @@
  * @param unexpected Not expected value.
  * @param actual Actual value.
  */
-#define assertNotEquals(message, unexpected, actual) if (unexpected == actual) { fail(message); } // TODO: expected vs. actual in message
+#define assertNotEquals(message, unexpected, actual) if ((unexpected) == (actual)) { fail(message); } // TODO: expected vs. actual in message
 
 /** Method signature for annotated test methods.
  * @see #A_Test


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Aceunit-commit] SF.net SVN: aceunit: [83] trunk/src/native/AceUnit.h

[<chr...@us...>]

Revision: 83
          http://aceunit.svn.sourceforge.net/aceunit/?rev=83&view=rev
Author:   christianhujer
Date:     2007-10-14 10:18:13 -0700 (Sun, 14 Oct 2007)

Log Message:
-----------
Fixed bug: macro parameters were not properly braced.

Modified Paths:
--------------
    trunk/src/native/AceUnit.h

Modified: trunk/src/native/AceUnit.h
===================================================================
--- trunk/src/native/AceUnit.h	2007-10-14 11:54:19 UTC (rev 82)
+++ trunk/src/native/AceUnit.h	2007-10-14 17:18:13 UTC (rev 83)
@@ -105,7 +105,7 @@
  * @param message Message, usually with the positive description of why the assertion should not fail.
  * @param condition Condition to assert.
  */
-#define assertTrue(message, condition) if (!condition) { fail(message); }
+#define assertTrue(message, condition) if (!(condition)) { fail(message); }
 
 /** Asserts that the specified condition is false.
  * If the condition is not false, the test case fails and raises an Assertion Error that will be logged.
@@ -120,7 +120,7 @@
  * @param expected Expected value.
  * @param actual Actual value.
  */
-#define assertEquals(message, expected, actual) if (!(expected == actual)) { fail(message); } // TODO: expected vs. actual in message
+#define assertEquals(message, expected, actual) if (!((expected) == (actual))) { fail(message); } // TODO: expected vs. actual in message
 
 /** Asserts that two values are not equal.
  * If the values are equal, the test case fails and raises an {@link AssertionError_t} that will be logged.
@@ -128,7 +128,7 @@
  * @param unexpected Not expected value.
  * @param actual Actual value.
  */
-#define assertNotEquals(message, unexpected, actual) if (unexpected == actual) { fail(message); } // TODO: expected vs. actual in message
+#define assertNotEquals(message, unexpected, actual) if ((unexpected) == (actual)) { fail(message); } // TODO: expected vs. actual in message
 
 /** Method signature for annotated test methods.
  * @see #A_Test


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.