Menu
▾
▴
Git Code Merge Request #1: Various fix performed during conan recipe creation (merged)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Martin Delille wants to merge 4 commits from /u/martindelille/aaf/ to master, 2021-12-20
Hi,
After adding an almost working conan recipe of this library (https://github.com/conan-io/conan-center-index/pull/7199), here are some improvement me and code reviewers added.
I would be very happy to see these change merge and would accept any remark.
Regards,
Martin
Martin Delille
Thanks for submitting these changes.
We've merged the pointer issue change.
The array count issue was fixed slightly differently using the existing kNumSupportedFlavours and fixing another instance as well, but thanks for spotting this issue nonetheless.
The register keyword change hasn't been merged because it's C-code and we checked that on Linux and Windows that the C-compiler is being used. The libjpeg code is quite old and the latest release is still using the register keyword.
The define interface change hasn't been merged because it doesn't appear to be an issue in the AAF SDK and it sounds like from https://github.com/conan-io/conan-center-index/pull/7199#issuecomment-918296959 that the cause is elsewhere.