Thread: [A-A-P-develop] Installing A-A-P with a non-existent PREFIX
Brought to you by:
vimboss
From: Johan S. <jo...@sv...> - 2004-01-16 22:00:41
|
Hi! Just a small suggestion for improvement when installing A-A-P with a non-existent PREFIX (i.e. aap install PREFIX=/no/such/path); I think it would be nice if A-A-P asked the user if it's ok to proceed and create the PREFIX directory. Currently it will just quit stating that /no/such/path isn't writable (yes, there is a typo in main.aap :-)). -- Johan Svedberg, jo...@sv..., http://johan.svedberg.pp.se/ |
From: Bram M. <Br...@mo...> - 2004-01-17 12:45:56
|
Johan Svedberg wrote: > Just a small suggestion for improvement when installing A-A-P with a > non-existent PREFIX (i.e. aap install PREFIX=/no/such/path); I think it > would be nice if A-A-P asked the user if it's ok to proceed and create > the PREFIX directory. Currently it will just quit stating that > /no/such/path isn't writable (yes, there is a typo in main.aap :-)). How about this patch: *** main.aap~ Thu Sep 25 20:53:34 2003 --- main.aap Sat Jan 17 13:29:25 2004 *************** *** 32,38 **** @if os.name == 'posix': PREFIX = `os.path.expanduser(_no.PREFIX)` @if not os.access(_no.PREFIX, os.W_OK): ! :error Install directory is not writable: $PREFIX # Get the version string from AapVersion.py, because $VERSIONSTR is # from the current Aap, which may be older. --- 32,45 ---- @if os.name == 'posix': PREFIX = `os.path.expanduser(_no.PREFIX)` @if not os.access(_no.PREFIX, os.W_OK): ! @if os.access(_no.PREFIX, os.R_OK): ! :error Install directory is not writable: $PREFIX ! @r = raw_input(('\nThe $PREFIX directory does not exist: "%s"\n' ! @ % _no.PREFIX) + ! @ "Do you want to try creating it? (y/n) ") ! @if not r or (r[0] != 'y' and r[0] != 'Y'): ! :error Install directory does not exist: $PREFIX ! :mkdir {r} $PREFIX # Get the version string from AapVersion.py, because $VERSIONSTR is # from the current Aap, which may be older. -- [clop clop] GUARD #1: Halt! Who goes there? ARTHUR: It is I, Arthur, son of Uther Pendragon, from the castle of Camelot. King of the Britons, defeator of the Saxons, sovereign of all England! GUARD #1: Pull the other one! The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ Project leader for A-A-P -- http://www.A-A-P.org /// \\\ Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html /// |
From: Scott H. <har...@ms...> - 2004-01-17 13:57:07
|
Okay, here is my spam-question-du-jour. > > non-existent PREFIX (i.e. aap install PREFIX=/no/such/path); I think it Does PREFIX work against everything (@install_files), or just against the default list of targets (install-data, install-exec, install-include, etc)? DESTDIR will automatically process for @install_files, right? Right now, I am doing something like this (which from reading the documentation and this thread is wrong): # The leading filesystem path (ordinarily blank, used for testing). PREFIX = # Filesystem locations DOCUMENTROOT = $(PREFIX)/usr/local/www/data WEBSERVERLOGS = $(PREFIX)/var/log sometarget: @install_files(_no.DOCUMENTROOT, etc.... Thanks for your help. Regards, Scott -- Scott Harrison <har...@ms...> Michigan State University |
From: Bram M. <Br...@mo...> - 2004-01-17 15:00:55
|
Scott Harrison wrote: > Okay, here is my spam-question-du-jour. > > > > non-existent PREFIX (i.e. aap install PREFIX=/no/such/path); I think it > > Does PREFIX work against everything (@install_files), or just against > the default list of targets (install-data, install-exec, > install-include, etc)? It works for everything. > DESTDIR will automatically process for @install_files, right? Yes. > Right now, I am doing something like this (which from reading > the documentation and this thread is wrong): > > # The leading filesystem path (ordinarily blank, used for testing). > PREFIX = > > # Filesystem locations > DOCUMENTROOT = $(PREFIX)/usr/local/www/data > WEBSERVERLOGS = $(PREFIX)/var/log > > sometarget: > @install_files(_no.DOCUMENTROOT, etc.... You can set $PREFIX to an empty string, but this has the meaning of installing in /usr/local. To really install in the root directory set it to "/". Is it a problem that install_files() always prepends $DESTDIR/$PREFIX to the directory passed to it? -- Veni, Vidi, Video -- I came, I saw, I taped what I saw. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ Project leader for A-A-P -- http://www.A-A-P.org /// \\\ Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html /// |
From: Scott H. <har...@ms...> - 2004-01-17 18:30:06
|
> > Does PREFIX work against everything (@install_files), or just against > > the default list of targets (install-data, install-exec, > > install-include, etc)? > It works for everything. > > DESTDIR will automatically process for @install_files, right? > Yes. > You can set $PREFIX to an empty string, but this has the meaning of > installing in /usr/local. To really install in the root directory set > it to "/". > > Is it a problem that install_files() always prepends $DESTDIR/$PREFIX > to the directory passed to it? The only small worry I have is PREFIX = / DESTDIR = / and winding up with a system call cp somefile ///usr/work/somewhere/. I think '//' and '///' is unclean, and vaguely recall it not being processed well by certain OS platforms or software applications. For example, if I were to use A-A-P to list the target files and it gave '//usr/somewhere/' that might cause things like RPM v3 to hiccup (in my experience). Not a big deal and maybe A-A-P is self-cleaning in this regard with specifying the target paths. That's the only problem I might imagine. Otherwise, I greatly like the dual prefixing modality provided by DESTDIR and PREFIX. //Scott/// |
From: Bram M. <Br...@mo...> - 2004-01-17 19:33:16
|
Scott Harrison wrote: > > You can set $PREFIX to an empty string, but this has the meaning of > > installing in /usr/local. To really install in the root directory set > > it to "/". > > > > Is it a problem that install_files() always prepends $DESTDIR/$PREFIX > > to the directory passed to it? > > The only small worry I have is > > PREFIX = / > DESTDIR = / > > and winding up with a system call > > cp somefile ///usr/work/somewhere/. The Python function os.path.join() is used, which deletes extra slashes. If you do see too many slashes somewhere, let me know and I can fix it. But I would not expect this to happen. > I think '//' and '///' is unclean, and vaguely > recall it not being processed well by certain > OS platforms or software applications. On some (old) systems //system/path was used for network access. -- GUARD #1: Where'd you get the coconut? ARTHUR: We found them. GUARD #1: Found them? In Mercea? The coconut's tropical! ARTHUR: What do you mean? GUARD #1: Well, this is a temperate zone. The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// Sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ Project leader for A-A-P -- http://www.A-A-P.org /// \\\ Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html /// |
From: Johan S. <jo...@sv...> - 2004-01-18 00:56:19
|
* Jan 17 13:46 Bram Moolenaar <Br...@mo...>: > > Johan Svedberg wrote: > > > Just a small suggestion for improvement when installing A-A-P with a > > non-existent PREFIX (i.e. aap install PREFIX=/no/such/path); I think > > it would be nice if A-A-P asked the user if it's ok to proceed and > > create the PREFIX directory. Currently it will just quit stating > > that /no/such/path isn't writable (yes, there is a typo in main.aap > > :-)). > > How about this patch: [...] Yes, I think that's better. -- Johan Svedberg, jo...@sv..., http://johan.svedberg.pp.se/ |