Thread: [Abook-devel] Trivial patch: Synonym for search-next, 'n'

Dear abook-devels,

I never quite understood why searching for the next matching item in
abook required me to use the backslash character rather than 'n'ext.
Apart from being defined like that by many ncurses-based interfaces, 'n'
has the advantage of being a single-key character in all latin* keyboard
configurations - the backslash sometimes involves an awkward
AltGr-combination (for example, in de).

As the 'n' key is not defined by abook at the moment, I propose to make
it a synonym for '\\'.  The corresponding one-line patch for 0.6.0pre2
is attached.

Best Regards,
  Hagen Fuchs

On 17.12.10,19:28, Hagen Fuchs wrote:
> Dear abook-devels,
> 
> I never quite understood why searching for the next matching item in
> abook required me to use the backslash character rather than 'n'ext.
> Apart from being defined like that by many ncurses-based interfaces, 'n'
> has the advantage of being a single-key character in all latin* keyboard
> configurations - the backslash sometimes involves an awkward
> AltGr-combination (for example, in de).
> 
> As the 'n' key is not defined by abook at the moment, I propose to make
> it a synonym for '\\'.  The corresponding one-line patch for 0.6.0pre2
> is attached.
> 
> Best Regards,
>   Hagen Fuchs
> 

> diff -rN -u old-abook-0.6.0pre2/ui.c new-abook-0.6.0pre2/ui.c
> --- old-abook-0.6.0pre2/ui.c	2010-12-17 19:17:32.468497621 +0100
> +++ new-abook-0.6.0pre2/ui.c	2010-12-17 19:17:32.472497572 +0100
> @@ -494,6 +494,7 @@
>  			case 'F': sort_by_field(NULL);	break;
>  
>  			case '/': ui_find(0);		break;
> +			case 'n':  // TODO Not in use, is it?
>  			case '\\': ui_find(1);		break;
>  
>  			case ' ': if(list_get_curitem() >= 0) {
> 

This looks like a useful patch. Will test it. Thanks!


Jostein

On Fri, Dec 17, 2010 at 07:28:43PM +0100, Hagen Fuchs wrote:
>Dear abook-devels,
>
>I never quite understood why searching for the next matching item in
>abook required me to use the backslash character rather than 'n'ext.
>Apart from being defined like that by many ncurses-based interfaces, 'n'
>has the advantage of being a single-key character in all latin* keyboard
>configurations - the backslash sometimes involves an awkward
>AltGr-combination (for example, in de).
>
>As the 'n' key is not defined by abook at the moment, I propose to make
>it a synonym for '\\'.  The corresponding one-line patch for 0.6.0pre2
>is attached.
>
>Best Regards,
>  Hagen Fuchs

Really, the next time '\' is pressed without any following chars,
should search for the next occurrence of the last searched char(s).

... And, trying to search for the next item doesn't seem to be working
too well here!  Looks like something is lacking, but I've only searched for one
or two letter chars so far.

-- 
Roger
http://rogerx.freeshell.org/

On Fri, Dec 17, 2010 at 07:28:43PM +0100, Hagen Fuchs wrote:
>Dear abook-devels,
>
>I never quite understood why searching for the next matching item in
>abook required me to use the backslash character rather than 'n'ext.
>Apart from being defined like that by many ncurses-based interfaces, 'n'
>has the advantage of being a single-key character in all latin* keyboard
>configurations - the backslash sometimes involves an awkward
>AltGr-combination (for example, in de).
>
>As the 'n' key is not defined by abook at the moment, I propose to make
>it a synonym for '\\'.  The corresponding one-line patch for 0.6.0pre2
>is attached.
>
>Best Regards,
>  Hagen Fuchs
>

>diff -rN -u old-abook-0.6.0pre2/ui.c new-abook-0.6.0pre2/ui.c
>--- old-abook-0.6.0pre2/ui.c	2010-12-17 19:17:32.468497621 +0100
>+++ new-abook-0.6.0pre2/ui.c	2010-12-17 19:17:32.472497572 +0100
>@@ -494,6 +494,7 @@
> 			case 'F': sort_by_field(NULL);	break;
> 
> 			case '/': ui_find(0);		break;
>+			case 'n':  // TODO Not in use, is it?
> 			case '\\': ui_find(1);		break;
> 
> 			case ' ': if(list_get_curitem() >= 0) {
>

I tested this patch and using 'n' does work.

The following chars probably aren't needed. ;-)

-// TODO Not in use, is it?

-- 
Roger
http://rogerx.freeshell.org/