i would like to bring to your attention that the macro player doesn't work like it used to
when using find string in the macro .. using f3 .etc
when playing it goes back to the first f3 but also does something weird to the line which is hard to explain
in short it doesn't work like it used to, i can only hope it will return to normal or become better ... there are other older stuff that i need to report concerning the macro recorder\player but im going to keep it pended down for now ;)
thanks
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This new bug is a side-effect of a feature introduced in, I believe, version 4.9.x to ensure that the highlighted line after a search is visible in the window (the window is automatically scrolled, as needed, after a search).
To correct the problem, I submitted one set of modifications to the v. 5.0 beta, but the modifications imposed some inelegance to the design interface of some classes in NP++, so Don declined those modifications (and I don't blame him). I submitted a second set of modifications that was, I think, more palatable in its changes to the interface. I have not heard anything more about that second set of modifications, so I don't know whether it was never received or whether is was also declined. Don or Harry, would you comment?
Regards.
Greg
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
> I submitted a second set of modifications that was,
> I think, more palatable in its changes to the interface.
> I have not heard anything more about that second set of modifications,
> so I don't know whether it was never received or whether is was also declined.
> Don or Harry, would you comment?
Sorry for not replying you yet. I'm busy for the new v5.0.1 release.
I'm not convinced that it's a good way to record some keystroke outside of Notepad_plus object.
So the solution of recording F3 in FindReplaceDlg is not included in Notepad++ v5.0.1.
I'll review the code to find a better way to capture these keystroke in macro recording.
In the meantime, if you have another solution, please let me know.
Don
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
>In the meantime, if you have another solution, please let me know.
Indeed I do have an idea for another proposed solution. It will be at least a week before I can send it to you.
Just to clarify, please note that the previously proposed solutions involved letting the FindReplaceDlg temporarily *suspend* macro recording after F3 (this is almost the opposite recording F3, as your message implies).
Here's the new idea. The 4.9.x modification to FindReplaceDlg -- the one to let it scroll the found selection into view -- involved FindReplaceDlg using some intimacy with ScintillaEditView. As you know, this ended up creating a problem for playing macros that recorded F3, as the scroll messages have some side-effects. The solutions I've so-far proposed for fixing this involved giving FindReplaceDlg additional intimacy -- this time with the Notepad_plus object. We agree that this is inelegant, at best. The new idea I'll be proposing is to take away some of the intimacy that FindReplaceDlg already has. Instead of allowing it to scroll the ScintillaEditViews directly, it must call a (new) method of the ScintillaEditView class to perform the scrolling, and this new method will be the one that may suspend, then resume, macro recording, as needed. So FindReplaceDlg will continue to know nothing about macro recording.
It will be at least a week before I can send you any code for this. In the meantime, I most welcome your comments.
Regards.
Greg
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
well i had posted this already
but i thought its better as a subject finally!
i would like to bring to your attention that the macro player doesn't work like it used to
when using find string in the macro .. using f3 .etc
when playing it goes back to the first f3 but also does something weird to the line which is hard to explain
in short it doesn't work like it used to, i can only hope it will return to normal or become better ... there are other older stuff that i need to report concerning the macro recorder\player but im going to keep it pended down for now ;)
thanks
This new bug is a side-effect of a feature introduced in, I believe, version 4.9.x to ensure that the highlighted line after a search is visible in the window (the window is automatically scrolled, as needed, after a search).
To correct the problem, I submitted one set of modifications to the v. 5.0 beta, but the modifications imposed some inelegance to the design interface of some classes in NP++, so Don declined those modifications (and I don't blame him). I submitted a second set of modifications that was, I think, more palatable in its changes to the interface. I have not heard anything more about that second set of modifications, so I don't know whether it was never received or whether is was also declined. Don or Harry, would you comment?
Regards.
Greg
> I submitted a second set of modifications that was,
> I think, more palatable in its changes to the interface.
> I have not heard anything more about that second set of modifications,
> so I don't know whether it was never received or whether is was also declined.
> Don or Harry, would you comment?
Sorry for not replying you yet. I'm busy for the new v5.0.1 release.
I'm not convinced that it's a good way to record some keystroke outside of Notepad_plus object.
So the solution of recording F3 in FindReplaceDlg is not included in Notepad++ v5.0.1.
I'll review the code to find a better way to capture these keystroke in macro recording.
In the meantime, if you have another solution, please let me know.
Don
Thank you, Don.
>In the meantime, if you have another solution, please let me know.
Indeed I do have an idea for another proposed solution. It will be at least a week before I can send it to you.
Just to clarify, please note that the previously proposed solutions involved letting the FindReplaceDlg temporarily *suspend* macro recording after F3 (this is almost the opposite recording F3, as your message implies).
Here's the new idea. The 4.9.x modification to FindReplaceDlg -- the one to let it scroll the found selection into view -- involved FindReplaceDlg using some intimacy with ScintillaEditView. As you know, this ended up creating a problem for playing macros that recorded F3, as the scroll messages have some side-effects. The solutions I've so-far proposed for fixing this involved giving FindReplaceDlg additional intimacy -- this time with the Notepad_plus object. We agree that this is inelegant, at best. The new idea I'll be proposing is to take away some of the intimacy that FindReplaceDlg already has. Instead of allowing it to scroll the ScintillaEditViews directly, it must call a (new) method of the ScintillaEditView class to perform the scrolling, and this new method will be the one that may suspend, then resume, macro recording, as needed. So FindReplaceDlg will continue to know nothing about macro recording.
It will be at least a week before I can send you any code for this. In the meantime, I most welcome your comments.
Regards.
Greg