Email stereotype and validation class

Hi Janes,

very good contribution.
I like it.

Kind regards,
Trifon

Hi Janesh,

your stereotypes EMAIL, TELEPHONE and WEBURL are included in OpenXava (in CVS HEAD).
They will be available for OpenXava 2.2.3

Also I have modified OpenXava/xava/validators.xml adding:

    <default-validator>
        <validator-class class="org.openxava.validators.EmailValidator"/>
        <for-stereotype stereotype="EMAIL"/>       
    </default-validator>
   
    <default-validator>
        <validator-class class="org.openxava.validators.PhoneNumberValidator"/>
        <for-stereotype stereotype="TELEPHONE"/>
        <for-stereotype stereotype="TELEFONO"/>
    </default-validator>
   
    <default-validator>
        <validator-class class="org.openxava.validators.URLValidator"/>
        <for-stereotype stereotype="WEBURL"/>
    </default-validator>   

Moreover I have created a test, included in CustomerWithSectionTest:
public void testTELEPHONE_EMAIL_WEBURLstereotypes() throws Exception {
        execute("Mode.detailAndFirst");
        setValue("telephone", "asf");
        setValue("email", "pepe");
        setValue("website", "openxava");
        execute("Customer.save");       
        assertError("Telephone must be a valid number");
        assertError("eMail must be a valid email address");
        assertError("Web site must be a valid url");
        setValue("telephone", "123");
        setValue("email", "pepe@mycompany");
        setValue("website", "www.openxava.org");
        execute("Customer.save");
        assertError("Telephone must be at least 8 Digits long");
        assertError("eMail must be a valid email address");
        assertError("Web site must be a valid url");
        assertValue("email", "pepe@mycompany"); // not converted to uppercase
        assertValue("website", "www.openxava.org"); // not converted to uppercase
        setValue("telephone", "961112233");
        setValue("email", "pepe@mycompany.com");
        setValue("website", "http://www.openxava.org");
        execute("Customer.save");
        assertNoErrors();
    }

And I have updated the Reference Guide.
All this (including the oro and commons-validations jars) are now included in OpenXava.

Thanks for your contribution.
Now you are part of OpenXava team. OpenXava is also your project.

Cheers
Javi

Hi Javi
I am glad to be a part of OpenXava and will continue to contribute to the project.

A friend of mine is working on Japanese trnslation. Once this is done we will be able to contribute it to OpenXava.

Thanking You
Janesh

Hi Javi
Email Validation class is improved using the  apache validator API.

Please find the class below.

import org.apache.commons.validator.GenericValidator;
import org.openxava.util.Messages;
import org.openxava.validators.IPropertyValidator;

/**
* @author Janesh Kodikara
*/

public class EmailValidator implements IPropertyValidator {

    public void validate(Messages errors, Object value, String propertyName, String modelName) throws Exception {

        if (value == null || value.toString().length() == 0) return;

        if (! GenericValidator.isEmail(value.toString())) {
            errors.add("email_validation_error", propertyName);
            return;
        }
    }

}

This API has lot of validation methods which simplify the coding.
I am thinking of writing more validation class for OpenXava using this API.
New Stereotypes can be introduced as these validation classes are introduced.

Can you please guide me to implement this?

Thanking You
Janesh

Hi Javi
I will love to have direct access.
But I will paste the stuff into the thread for sometime.

The qaManager reached 30 sometime back. :-)

I want to learn Hibernate and Java and contribute to OpenXava.
Any suggestions? I mean what should I learn to build competancy while contributing to the project slowly.

Cheers
Janesh