I see that the Finnish language file still uses as the thousands separator. Could you change that to " ", if POPFile still allows only one character as the separator.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
> since I can't get the HTML test suite to
> run on Windows, I'd have to add it blindly.
Never mind that (at least in the present context). Since I don't need the test suite to fork, I was able to add a test for pretty_number. Hope that's what you had in mind.
Manni
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It would be appreciated if a win user of RC2 would run it thru a schema upgrade to make absolutely sure the MySQL fixes didn't create any subtle problems on the win platform. Works fine on Linux.
To simulate an upgrade, simply shutdown POPFile and use the SQLite commandline utility to change the schema version, e.g.,
sqlite popfile.db
SQLite version 2.8.12
Enter ".help" for instructions
sqlite> update popfile set version = 2;
sqlite> .q
Then restart POPFile, it should see that the schema needs 'upgrading' and go thru the upgrade code.
I don't anticipate there will be any issues, but would like to be 100% sure.
Thanks,
Scott
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Folks,
I've posted the RC2 for v0.22.1 which adds:
1. Updated Arabic translation
2. MySQL compatibility
3. Fix for problem with null characters in headers
http://popfile.sf.net/popfile-0.22.1RC2.zip
http://popfile.sf.net/popfile-0.22.1RC2-windows.zip
John.
I see that the Finnish language file still uses as the thousands separator. Could you change that to " ", if POPFile still allows only one character as the separator.
is a non breaking space, in the browser it appears the same as " ". Is there some reason its a problem?
Oh yes! Try it and have a look at the buckets page.
The problem is that the function pretty_number will mess up if it's given more than one char as a divider will break down and return a mess.
But we also cannot simply use a real space in the language file because the code that loads the language file is throwing away all the white space.
This sucks. Jan-Erik! Is there nothing else we could use to make the Finns happy?
Manni
Entries in the language file can be placed in quotes "" and spaces will be preserved.
Yes we could do your fix and since it adds flexibility let's do it too. Would you mind adding a test case for this?
John.
> Entries in the language file
> can be placed in quotes ""
> and spaces will be preserved.
Oops. Should have had a look at the code.
> Yes we could do your fix and since
> it adds flexibility let's do it too.
OK, I'll check it in.
> Would you mind adding a test case for this?
Not at all. But since I can't get the HTML test suite to run on Windows, I'd have to add it blindly.
Manni
> since I can't get the HTML test suite to
> run on Windows, I'd have to add it blindly.
Never mind that (at least in the present context). Since I don't need the test suite to fork, I was able to add a test for pretty_number. Hope that's what you had in mind.
Manni
OK. I just had another look at pretty_number(). John! We could fix this by using the reverse of $self->{language__}{Locale_Thousands}.
Manni
John,
I've posted the updated Nihongo.msg (translation fix) in the patch section.
http://sourceforge.net/tracker/index.php?func=detail&aid=1032710&group_id=63137&atid=502958
Please merge this patch.
Naoki
It would be appreciated if a win user of RC2 would run it thru a schema upgrade to make absolutely sure the MySQL fixes didn't create any subtle problems on the win platform. Works fine on Linux.
To simulate an upgrade, simply shutdown POPFile and use the SQLite commandline utility to change the schema version, e.g.,
sqlite popfile.db
SQLite version 2.8.12
Enter ".help" for instructions
sqlite> update popfile set version = 2;
sqlite> .q
Then restart POPFile, it should see that the schema needs 'upgrading' and go thru the upgrade code.
I don't anticipate there will be any issues, but would like to be 100% sure.
Thanks,
Scott
I tested RC2 on WinXP.
After "Restoring old data" message, I saw several errors like:
DBD::SQLite::db do failed: PRIMARY KEY must be unique
at C:\PROGRA~1\POPFile/Classifier/Bayes.pm line 782, <INSERT> line xxx.
However, I got "Database upgrade complete" message at the end and so far it works fine.
Whole log is at:
http://www.3mon.com/wiki/wiki.cgi?POPFileLog
Junya
Thanks ! Those primary key messages are 'normal' in the sense that they happen with or without the MySQL changes.
Your log looked fine. Thanks for checking it out for me.
Scott