-
>I've added the message parameter for the case that we have to use a
>different error message. For example:
>self._checkReadable("Can't read from a closed socket")
Ok, I can see how that would be useful in the future even if it happens not
to be used in your patch -- forget my previous comment.
>I've done a lot of Zope, twisted and Qt development lately. I prefer camel
>case but you...
2007-08-19 16:49:47 UTC in Python
-
Your English is fine :)
The _checkSeekable etc methods are a good idea. But the message parameter is not used, so why have it?
They should be lowercase names to match PEP 8.
Also, shouldn't use the internal methods on parameters other than self:
- assert raw.seekable()
+ raw._checkSeekable()
I'm not sure it's a good idea to do the first todo without the second here...
2007-08-18 17:41:57 UTC in Python
-
Thanks for the comments.
Re: "stuff", if you look at other parts of the code, that is how the triple is referred to -- fyi on how the name "stuff" came to be :) I was also at a loss for a better name, and went with the contextual references.
Re: using 2to3 -- Brett, in many cases I actually tried to come up with a consistent name. IIRC 2to3 will put in XXX_fixme_123 or something like that...
2007-03-22 21:53:11 UTC in Python
-
I found some more code to be removed + a docstring fix in inspect.py. getfullargspec's docstring lists the
wrong order for return values. This patch combined the refmanual patch, previous simplified args patch,
and 2to3 changes on some doc building tools.
File Added: simplified-args.patch.
2007-03-12 15:07:32 UTC in Python
-
File Added: refmanual.patch.
2007-03-11 22:34:18 UTC in Python
-
Remove tuple parameter unpacking. The Grammar is now:
typedargslist: ((tfpdef ['=' test] ',')*
('*' [tfpdef] (',' tfpdef ['=' test])* [',' '**' tfpdef] | '**' tfpdef)
| tfpdef ['=' test] (',' tfpdef ['=' test])* [','])
tfpdef: NAME [':' test]
varargslist: ((vfpdef ['=' test] ',')*
('*' [vfpdef] (',' vfpdef ['=' test])* [',' '**' vfpdef] |...
2007-03-10 21:34:17 UTC in Python
-
File Added: pydoc.patch.
2007-02-28 03:23:25 UTC in Python
-
File Added: make_closure_fix.patch.
2007-01-14 20:32:13 UTC in Python
-
Combines the code paths for MAKE_FUNCTION and MAKE_CLOSURE.
Fixes a crash where functions with closures and either annotations or
keyword-only arguments result in MAKE_CLOSURE, but only
MAKE_FUNCTION has the code to handle annotations or keyword-only
arguments.
Includes enough tests to trigger the bug.
2007-01-14 20:31:31 UTC in Python
-
I tried to implement getargspec() as described, and unfortunately there
is another wrinkle to consider. Keyword-only arguments may or may not
have defaults. So the invariant described in getargspec()'s docstring can't
be maintained when simply appending keyword-only arguments.
A tuple of four things is returned: (args, varargs, varkw, defaults).
'args' is a list of the argument...
2007-01-06 21:03:32 UTC in Python
