-
Patches look good.Applied to master and pushed.
2009-11-04 04:01:46 UTC in The Chemistry Development Kit
-
Patch 1 worked fine, but patch 2 fails on latest master
....
import java.util.List;
error: patch failed: build.xml:985
error: build.xml: patch does not apply
warning: src/main/org/openscience/cdk/config/ElementPTFactory.java has type 100755, expected 100644
error: patch failed: src/main/org/openscience/cdk/fingerprint/Fingerprinter.java:36
error...
2009-11-02 04:15:15 UTC in The Chemistry Development Kit
-
Looks good. However, I pulled these into master by mistake. Can you merge these 2 commits specifically into cdk-1.2.x?.
2009-11-01 18:02:54 UTC in The Chemistry Development Kit
-
There are no patches attached.
2009-11-01 17:22:36 UTC in The Chemistry Development Kit
-
Looks good. Applied to master and pushed.
2009-11-01 17:21:06 UTC in The Chemistry Development Kit
-
Ok, it's for master since it depends on a patch applied to master.
2009-11-01 17:17:36 UTC in The Chemistry Development Kit
-
Is this for 1.2.x or master?.
2009-11-01 17:15:43 UTC in The Chemistry Development Kit
-
Latest patches applied and pushed.
2009-11-01 16:34:54 UTC in The Chemistry Development Kit
-
Patch still fails
Applying: Fixed unit tests: the IChemModel.setFoo(null) should actually give a change event on the listener of the IChemModel
error: patch failed: src/test/org/openscience/cdk/interfaces/AbstractChemModelTest.java:228
error: src/test/org/openscience/cdk/interfaces/AbstractChemModelTest.java: patch does not apply
Patch failed at 0001.
2009-11-01 15:14:43 UTC in The Chemistry Development Kit
-
Looks good. applied ot master and pushed.
2009-11-01 15:11:26 UTC in The Chemistry Development Kit