-
Russel Coker thinks you're too sloppy with const among other things. See http://bugs.debian.org/524133. Here is a patch. Naturally, you have to enable warnings to see them. :-)
2009-08-02 20:23:16 UTC in Alt-N Technologies DKIM Project
-
Russel Coker pointed out (see http://bugs.debian.org/532740) that libdkim uses strtok(), which is not reentrant, making libdkim unsuitable in multithreaded applications. His patch is attached.
2009-08-02 19:22:47 UTC in Alt-N Technologies DKIM Project
-
It would be nice if you could let policy.t and public_key.t share the "fake DNS" in verifier.t, such that the test suite doesn't depend on the Internet being available.
(The build environment on Debian's autobuilders doesn't provide network connectivity, and anyway, Internet connections fail now and then and I don't think that should cause unit tests to fail.)
2009-08-01 16:37:31 UTC in DKIMproxy