Karthik Ravikanti

What's happening?

Tie breaker resolution

In ppp/ppp_l2tp_ctrl.c: You say: else if (ptrs->tiebreaker == NULL) /* i win */ diff = -1; but later after a couple of lines you say: if (diff > 0) { /* i win */ CLOG(LOG_NOTICE, "SCCRQ tie: peer loses"); Correction: Replace "diff >0" with "diff < 0".

2008-09-05 12:30:21 UTC in Packet Design Embedded Library
Incorrect transition in the CCE state machine

Line 1666 in l2tp_tunnel.c: { STATE(WAITCTLREPLY), EVENT(OPEN_REQ), ACTION(null), STATE(CLOSING) }, Why would we want to go to CLOSING if a local OPEN_REQ occurs here? It is possible that we already sent the SCCRQ and meanwhile got a duplicate request from the manager. So I feel we should instead remain in the WAITCTLREPLY state. Also, why would one go to CLOSING...

2008-09-02 12:21:24 UTC in OpenL2TP