-
I've spent several hours on this and keep finding cases where fixes don't work. Both of my prior fixes were incorrect because we need the timezone to end up being the zone that the user requested and icaltimezone_convert_time() does not update that field. I believe that the correct solution is this:
tt.is_utc = 1;
tt.is_daylight = 0;
tt.zone = utc_zone;
/* Use our timezone...
2008-11-15 20:20:08 UTC in Free Association (libical)
-
I missed a boundary case in my first round of testing, where it's legal to create a floating time using this function. The correct fix is:
tt.zone = zone ? utc_zone : NULL;
This fix also shows errors in the regression tests in regression.c. The second time that do_test_time() is called, zone is set to America/Los_Angeles. The function then calls icaltime_from_timet_with_zone() and expects the...
2008-11-15 08:08:03 UTC in Free Association (libical)
-
If icaltime_from_timet_with_zone() is passed caltimezone_get_utc_timezone() as the timezone, then it creates a floating time instead of a utc time because tt.zone is initialized with NULL and icaltimezone_convert_time does nothing because the from/to timezones match.
The fix is to change this:
tt.zone = NULL;
to this:
tt.zone = utc_zone;
This problem shows as a failure in...
2008-11-15 06:12:34 UTC in Free Association (libical)
-
I think there's a point of confusion here. You can't change the license of those files without documentation that Critical Path understood the licensing of the files when they were submitted (or specific permission from Critical Path).
2008-03-25 17:55:09 UTC in Free Association (libical)
-
I am trying to add 1 (one) day to an icaltimetype structure. The code looks like this:
icaltimetype tt = {0};
tt.ical.is_date = true;
tt.year = 2008;
tt.month = 3;
tt.day = 28;
tt.hour = 0;
tt.minute = 0;
tt.second = 0;
tt.is_utc = true;
tt.is_date = true;
tt.is_daylight = false;
struct icaldurationtype d = {0};
d.days = 1;
ical = icaltime_add(ical, d);
The...
2008-03-18 23:15:51 UTC in Free Association (libical)
-
I think there's still a problem - if I read the diffs in svn properly, it looks like the debug printf() statements were checked in?.
2008-02-26 04:47:09 UTC in Free Association (libical)
-
All of the C++ files (such as icptrholder.h, vcomponent.h, etc.) are labeled as:
(C) COPYRIGHT 2001, Critical Path
These files do not show the MPL/LGPL license. Since these files are marked as Copyright by Critical Path and have no other information about licensing or redistribution, they must be treated as unlicensed files that are not usable by 3rd parties.
Can this problem be resolved...
2008-02-06 21:18:12 UTC in Free Association (libical)
-
This bug is for libical v0.30.
In icalparser.c, the function icalparser_add_line() sometimes calls free on a different pointer than it receives from malloc(), causing a memory leak.
On line 960, you'll see these two lines:
str = parser_get_next_value(end,&end, value_kind);
str = strstrip (str);
Note that strstrip() passes back a new value for str. The new value is then passed to free()
2008-02-06 04:45:11 UTC in Free Association (libical)
-
jbeveridge registered the Bad Cluster Sweeper project.
2007-03-28 15:05:20 UTC in Bad Cluster Sweeper
