-
Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const-correctness" to more places in your sources?
I suggest to add the key word "const" to the type specifiers for parameters like the following.
- http://linuxquota.cvs.sourceforge.net/viewvc/linuxquota/quota-tools/quotacheck.h?revision=1.6&view=markup
fmtstr (function "debug")
filename (functions...
2009-12-30 09:27:51 UTC in Linux DiskQuota
-
Would you like to replace any defines for constant values by enumerations to stress their relationships?
http://linuxquota.cvs.sourceforge.net/viewvc/linuxquota/quota-tools/quota.h?revision=1.10&view=markup
http://linuxquota.cvs.sourceforge.net/viewvc/linuxquota/quota-tools/quotaio.h?revision=1.14&view=markup.
2009-12-30 09:05:46 UTC in Linux DiskQuota
-
I suggest to try the search pattern "\
2009-12-30 08:57:54 UTC in Linux DiskQuota
-
Some checks for return codes are missing.
Examples:
Would you like to add more error handling for return values from "putchar" like in the function "blit" and from "fputs" in the function "format_print"?
http://linuxquota.cvs.sourceforge.net/viewvc/linuxquota/quota-tools/quotacheck.c?revision=1.58&view=markup...
2009-12-30 08:46:51 UTC in Linux DiskQuota
-
Would you like to replace any defines for constant values by enumerations to stress their relationships?
http://portmedia.svn.sourceforge.net/viewvc/portmedia/portsmf/trunk/mfmidi.h?revision=156&view=markup
http://portmedia.svn.sourceforge.net/viewvc/portmedia/portsmf/trunk/apps/midicode.h?revision=51&view=markup.
2009-12-28 15:40:29 UTC in PortMedia
-
I suggest to convert a parameter like "attr", "measure" and "m_beat" from a pointer to a reference.
http://portmedia.svn.sourceforge.net/viewvc/portmedia/portsmf/trunk/allegro.h?revision=154&view=markup
http://en.wikipedia.org/wiki/Reference_(C%2B%2B)#Relationship_to_pointers
Can such an interface design adjustment be applied on other places in the source code, too?.
2009-12-28 15:11:48 UTC in PortMedia
-
Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const-correctness" to more places in your sources?
I suggest to add the key word "const" to the type specifiers for parameters like the following.
- http://portmedia.svn.sourceforge.net/viewvc/portmedia/portsmf/trunk/allegro.h?revision=154&view=markup
value (function "set_string_value")
attr (functions...
2009-12-28 15:01:16 UTC in PortMedia
-
I suggest to try the search pattern "\
2009-12-28 14:28:53 UTC in PortMedia
-
I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?.
2009-12-28 14:12:45 UTC in PortMedia
-
Danke für das "Öffnen der Tür".
Möchtest Du passend zur Mail-Kommunikation hier einen Kommentar ergänzen?.
2009-12-24 12:51:06 UTC in simon
