-
The Java execution performance can be improved if some thread-safe objects will be replaced by unsynchronised ones.
Example conversions:
- StringBuffer ⇒ StringBuilder
- Collections Framework: Hashtable ⇒ HashMap
Can it be detected if thread-safe objects are created while they are only used in a single method implementation so that the usage of unsynchronised interfaces interfaces...
2009-11-03 21:23:32 UTC in FindBugs
-
You do not need to make assumptions about error situations. Please check all error codes.
Otherwise, it might not be noticed if anything unexpected went wrong.
I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?
Would you like to reduce the efforts for error code checking by an exception class hierarchy?...
2009-11-01 12:58:11 UTC in WinDjView
-
Some checks for return codes are missing.
Examples:
Would you like to add more error handling for return values from "SetWindowsHookEx" like in the function "CDjViewApp::DoMessageBox" and from "GetModuleFileName" in the function "CDjViewApp::RegisterShellFileTypes"?
http://windjview.cvs.sourceforge.net/viewvc/windjview/windjview/WinDjView.cpp?revision=1.124&view=markup.
2009-10-28 15:27:03 UTC in WinDjView
-
I suggest to add at least one namespace to the source files.
http://rtaudio.svn.sourceforge.net/viewvc/rtaudio/trunk/RtAudio.h?revision=45&view=markup
Would you like to reduce the probability for name clashes?
http://www.eng.cam.ac.uk/help/tpl/languages/C++/Thinking_in_C++/tic0110.html
http://en.wikipedia.org/wiki/Namespace_(computer_science)#Use_in_common_languages.
2009-10-28 11:42:20 UTC in RtAudio
-
Would you like to combine your checks for this programming interface with the capabilities from the configuration script "ACX_PTHREAD"?
http://ac-archive.sourceforge.net/ac-archive/acx_pthread.html
http://rtaudio.svn.sourceforge.net/viewvc/rtaudio/trunk/configure.ac?revision=44&view=markup.
2009-10-27 21:52:40 UTC in RtAudio
-
I have seen that no loops are used around the calls of the function "pthread_cond_wait" like in the member function "RtApiAlsa::callbackEvent".
http://rtaudio.svn.sourceforge.net/viewvc/rtaudio/trunk/RtAudio.cpp?revision=45&view=markup
Would you like to reuse anything from my message on the topic "spurious wakeup"?
http://groups.google.de/group/comp.programming.threads/msg/bb8299804652fdd7.
2009-10-27 21:40:13 UTC in RtAudio
-
Some checks for return codes are missing.
Examples:
Would you like to add more error handling for return values from "pthread_mutex_init" like in the RtApi constructor and from "jack_set_process_callback" in the member function "RtApiJack::probeDeviceOpen"?
http://rtaudio.svn.sourceforge.net/viewvc/rtaudio/trunk/RtAudio.cpp?revision=45&view=markup.
2009-10-27 20:33:24 UTC in RtAudio
-
I guess that your software can not be treated as a compiler. Names that start with two underscores like "__RTAUDIO_H" and "__RTAUDIO_DUMMY__" should be avoided.
http://rtaudio.svn.sourceforge.net/viewvc/rtaudio/trunk/RtAudio.h?revision=45&view=markup
A few parts of your source files do not fit to the expected naming conventions of the C/C++ language standard.
-...
2009-10-27 20:05:19 UTC in RtAudio
-
Methods like "append" and "insert" exist that accept a single character additional to strings as a parameter. I guess that this can be executed a bit more efficiently than the other interface.
http://java.sun.com/javase/6/docs/api/java/lang/StringBuilder.html#append(char)
I suggest to detect the places in Java byte/source code where string objects are passed that contain only one character...
2009-10-25 09:42:01 UTC in FindBugs
-
elfring committed revision 1036 to the simon SVN repository, changing 241 files.
2009-10-01 14:37:42 UTC in simon
